[XamlC] Avoid calling ResourceDictionary.SetAndLoadSource #20776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDelcroix
previously approved these changes
Mar 11, 2024
rmarinho
requested changes
Mar 18, 2024
There was a problem hiding this comment.
Build is failing
D:\a\_work\1\s\.buildtasks\Microsoft.Maui.Controls.targets(154,3): error : Member '__XamlGeneratedCode__.__TypeD79CA40995E82F1C' is declared in another module and needs to be imported [D:\a\_work\1\s\src\Controls\tests\Xaml.UnitTests\Controls.Xaml.UnitTests.csproj]
7057 Warning(s)
1 Error(s)
|
@rmarinho please take another look, that bug is fixed now |
|
This would be a breaking change right? so we would need a breaking change doc ? |
|
@rmarinho yes, this would be a breaking change in .NET 9. The API is not supposed to be used by developers directly. The XamlC generates calls to these methods. |
rmarinho
approved these changes
Mar 26, 2024
StephaneDelcroix
approved these changes
Mar 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR adds a separate method in
ResourceDictionarythat compiledRDSourceTypeConvertercan call and which will be more efficient.The old
SetAndLoadSourceis still needed when we're parsing XAML at runtime. It doesn't have to be public anymore because it is now only intended to be called from the non-compiledRDSourceTypeConverter.Issues Fixed
Fixes #19648