Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the trailing .0 to all the windows things #20792

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

mattleibow
Copy link
Member

Description of Change

This is just to be consistent and avoid a potential issue I saw when testing the potential Win2D update. I am not sure why this is needed, but appears to sometimes be needed in net7.0 scenarios.

This is just to be consistent and avoid a potential issue I saw when
testing the potential Win2D update. I am not sure why this is needed,
but appears to sometimes be needed in net7.0 scenarios.
@mattleibow mattleibow requested a review from a team as a code owner February 22, 2024 20:28
@mattleibow mattleibow changed the title Add the trailing .0 to all the things Add the trailing .0 to all the windows things Feb 22, 2024
@rmarinho
Copy link
Member

Failing tests not related

@rmarinho rmarinho merged commit 0de4f22 into main Feb 23, 2024
43 of 47 checks passed
@rmarinho rmarinho deleted the dev/tfm-version branch February 23, 2024 15:59
rmarinho pushed a commit that referenced this pull request Feb 27, 2024
This is just to be consistent and avoid a potential issue I saw when
testing the potential Win2D update. I am not sure why this is needed,
but appears to sometimes be needed in net7.0 scenarios.
rmarinho added a commit that referenced this pull request Feb 27, 2024
This reverts commit 0de4f22.

# Conflicts:
#	eng/devices/windows.cake
#	eng/pipelines/common/ui-tests.yml
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants