[iOS] Fix UI loop when setting ContentInset #21140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarinho
changed the title
rmarinho
commented
Mar 14, 2024
| } | ||
|
|
||
| if (formsElement != null) | ||
| { |
Member
Author
There was a problem hiding this comment.
These changes on this file is just small cleanup and seems we need braces now :)
jsuarezruiz
previously approved these changes
Mar 15, 2024
mattleibow
previously approved these changes
Mar 15, 2024
rmarinho
force-pushed
the
20294-ios-collectionview-containing-a-footer-and-a-border-with-strokethickness-set-to-decimal-value-crashes-on-scroll
branch
from
affee26 to
7f789a3
Compare
Contributor
|
Total execution time: 1.47 seconds |
&color=red)
rmarinho
force-pushed
the
20294-ios-collectionview-containing-a-footer-and-a-border-with-strokethickness-set-to-decimal-value-crashes-on-scroll
branch
from
7f789a3 to
fe24a31
Compare
PureWeen
approved these changes
Mar 15, 2024
Member
|
Test failures aren't related to this PR this PR only touches iOS and the failures are known flakey areas on Android/Windows |
PureWeen
deleted the
20294-ios-collectionview-containing-a-footer-and-a-border-with-strokethickness-set-to-decimal-value-crashes-on-scroll
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Seems that we are always firing the bonds change even If they don't change, for example when the Bounds are similar when using CloseTo we should treat as the Bounds didn't change, but the code was always returning true there.
This issue also happens because when we use a footer we also set insets to the CollectionView that cause the Bounds event to change
Fixes #20294
Fixes #20320