Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Remove IgnoreIfPlatforms usage on UITests #22526

Merged
merged 11 commits into from
Jun 7, 2024
Merged

[Testing] Remove IgnoreIfPlatforms usage on UITests #22526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d759a72
Remove IgnoreIfPlatforms usage on UITests
jsuarezruiz May 20, 2024
7d67f2c
Changes in failing test
jsuarezruiz May 21, 2024
50bc881
Re-enabled tests in some platforms
jsuarezruiz May 21, 2024
abd1c47
Moved comment
jsuarezruiz May 21, 2024
86b7b7f
Changes based on PR feedback
jsuarezruiz May 21, 2024
4abf06b
Fixed test errors
jsuarezruiz May 21, 2024
17a9b46
Merge branch 'main' into fix-22525
jsuarezruiz May 22, 2024
347366f
Fix build errors
jsuarezruiz May 22, 2024
2d7992d
Ignore golden tests on macOS for now
jsuarezruiz May 27, 2024
8ac4b13
Merge branch 'main' into fix-22525
jsuarezruiz May 27, 2024
4ec9287
Updated test
jsuarezruiz May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions src/Controls/tests/TestCases.Shared.Tests/IUITestContextExtensions.cs
View file
Open in desktop

This file was deleted.

5 changes: 1 addition & 4 deletions ...stCases.Shared.Tests/Tests/CollectionView/CollectionViewUITests.MultipleBoundSelection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,9 @@ public CollectionViewBoundMultiSelectionUITests(TestDevice device)
// ItemsFromViewModelShouldBeSelected (src\Compatibility\ControlGallery\src\Issues.Shared\CollectionViewBoundMultiSelection.cs)
[Test]
[Category(UITestCategories.CollectionView)]
[Ignore("Click does not find CollectionView elements.")]
[FailsOnAllPlatforms("Click does not find CollectionView elements.")]
public void ItemsFromViewModelShouldBeSelected()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.iOS, TestDevice.Mac, TestDevice.Windows },
"Click does not find CollectionView elements.");

// Navigate to the selection galleries
VisitInitialGallery("Selection");

Expand Down
5 changes: 1 addition & 4 deletions ...TestCases.Shared.Tests/Tests/CollectionView/CollectionViewUITests.SingleBoundSelection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,10 @@ public CollectionViewSingleBoundSelectionUITests(TestDevice device)
/*
// SelectionShouldUpdateBinding (src\Compatibility\ControlGallery\src\Issues.Shared\CollectionViewBoundSingleSelection.cs)
[Test]
[Ignore("Click does not find CollectionView elements")]
[FailsOnAllPlatforms("Click does not find CollectionView elements")]
[Description("Single Selection Binding")]
public void SelectionShouldUpdateBinding()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.iOS, TestDevice.Mac, TestDevice.Windows },
"Click does not find CollectionView elements");

// Navigate to the selection galleries
VisitInitialGallery("Selection");

Expand Down
4 changes: 1 addition & 3 deletions ...ases.Shared.Tests/Tests/CollectionView/CollectionViewUITests.VisitAndUpdateItemsSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,9 @@ public VisitAndUpdateItemsSourceUITests(TestDevice device)
[TestCase("DataTemplate", "VerticalGridCode", 19, 6)]
[TestCase("DataTemplate", "HorizontalGridCode", 19, 6)]
[Category(UITestCategories.CollectionView)]
[FailsOnWindows("This test is failing, likely due to product issue.")]
public void VisitAndUpdateItemsSource(string collectionTestName, string subGallery, int firstItem, int lastItem)
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Windows },
"This test is failing, likely due to product issue.");

try
{
VisitInitialGallery(collectionTestName);
Expand Down
5 changes: 2 additions & 3 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/GestureRecognizerUITests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,10 @@ protected override void FixtureSetup()

[Test]
[Category(UITestCategories.Gestures)]
[FailsOnAndroid("PointerGestureRecognizer doesn't work with mouse in Android")]
[FailsOnIOS("PointerGestureRecognizer doesn't work with mouse in iOS")]
public void PointerGestureTest()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.iOS },
"PointerGestureRecognizer doesn't work with mouse in Android or iOS");

App.WaitForElement("TargetView");
App.EnterText("TargetView", "PointerGestureRecognizerEvents");
App.Tap("GoButton");
Expand Down
9 changes: 4 additions & 5 deletions ...ols/tests/TestCases.Shared.Tests/Tests/Issues/CarouselViewUITests.AdjustPeekAreaInsets.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using NUnit.Framework;
#if ANDROID
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

Expand All @@ -19,11 +20,9 @@ public CarouselViewAdjustPeekAreaInsets(TestDevice device)
[Category(UITestCategories.CarouselView)]
public void ChangePeekAreaInsetsInOnSizeAllocatedTest()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.iOS, TestDevice.Mac, TestDevice.Windows },
"Android specific Test");

App.WaitForElement("CarouselId");
}
*/
}
}
}
#endif
26 changes: 6 additions & 20 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/CarouselViewUITests.LoopNoFreeze.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,30 +6,23 @@ namespace Microsoft.Maui.TestCases.Tests.Issues
{
public class CarouselViewLoopNoFreeze : _IssuesUITest
{
readonly string _carouselAutomationId = "carouselView";
readonly string _btnRemoveAutomationId = "btnRemove";
readonly string _btnRemoveAllAutomationId = "btnRemoveAll";

public CarouselViewLoopNoFreeze(TestDevice device)
: base(device)
{
}

public override string Issue => "CarouselView Loop=True default freezes iOS app";

/*
readonly string _carouselAutomationId = "carouselView";
readonly string _btnRemoveAutomationId = "btnRemove";
readonly string _btnRemoveAllAutomationId = "btnRemoveAll";

// Issue12574 (src\ControlGallery\src\Issues.Shared\Issue12574.cs
[Test]
[Category(UITestCategories.CarouselView)]
[Ignore("Currently fails")]
[FailsOnAllPlatforms("Currently fails; see https://github.com/dotnet/maui/issues/19488")]
public void Issue12574Test()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.iOS },
"Currently fails on iOS; see https://github.com/dotnet/maui/issues/19488");

this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.Mac, TestDevice.Windows },
"iOS specific Test");

App.WaitForNoElement("0 item");

var rect = App.FindElement(_carouselAutomationId).GetRect();
Expand All @@ -55,21 +48,14 @@ public void Issue12574Test()

[Test]
[Category(UITestCategories.CarouselView)]
[Ignore("Currently fails")]
[FailsOnAllPlatforms("Currently fails; see https://github.com/dotnet/maui/issues/19488")]
public void RemoveItemsQuickly()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.iOS },
"Currently fails on iOS; see https://github.com/dotnet/maui/issues/19488");

this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.Mac, TestDevice.Windows },
"iOS specific Test");

App.WaitForNoElement("0 item");
App.Click(_btnRemoveAllAutomationId);

// If we haven't crashed, then the other button should be here
App.WaitForElement(_btnRemoveAutomationId);
}
*/
}
}
3 changes: 1 addition & 2 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/CarouselViewUITests.NoItemTemplate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,9 @@ public CarouselViewNoItemTemplate(TestDevice device)
// Issue12777 (src\ControlGallery\src\Issues.Shared\Issue12777.cs
[Test]
[Category(UITestCategories.CarouselView)]
[FailsOnWindows("This test is failing, likely due to product issue")]
public void Issue12777Test()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Windows });

App.WaitForElement("TestCarouselView");
App.Screenshot("Test passed");
}
Expand Down
7 changes: 3 additions & 4 deletions ...trols/tests/TestCases.Shared.Tests/Tests/Issues/CarouselViewUITests.PositionVisibility.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using NUnit.Framework;
#if ANDROID
using NUnit.Framework;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this one (and other #if statements) should we consider not adding this? Ideally tests run for all platforms unless there is something REALLY specific which I don't think should be a lot of tests. What if we just enable them, will they run fine on other platforms as well and suddenly get a lot of extra tests "for free"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe if we don't want to fix that right now then let's make sure there is an issue for it to go over these and test that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, but we need to review every case. I mean, there are many cases that just was validating something in one specific platform and the test only have the reference snapshot for that platform. We just need to generate the rest and validate it.

I can do that in this PR if we want, or create another issue an review it there.

using NUnit.Framework.Legacy;
using UITest.Appium;
using UITest.Core;
Expand All @@ -19,9 +20,6 @@ public CarouselViewPositionVisibility(TestDevice device)
[Category(UITestCategories.CarouselView)]
public void Issue12848Test()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.iOS, TestDevice.Mac, TestDevice.Windows },
"Android specific Test");

App.WaitForElement("TestCarouselView");
App.SwipeRightToLeft("TestCarouselView");
var position1 = App.FindElement("CarouselPosition").GetText();
Expand All @@ -36,3 +34,4 @@ public void Issue12848Test()
}
}
}
#endif
14 changes: 5 additions & 9 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/CarouselViewUITests.RemoveAt.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using NUnit.Framework;
#if IOS
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

Expand All @@ -16,20 +17,15 @@ public CarouselViewRemoveAt(TestDevice device)
// Issue10300 (src\ControlGallery\src\Issues.Shared\Issue10300.cs
[Test]
[Category(UITestCategories.CarouselView)]
[Ignore("Currently fails")]
[FailsOnIOS("Currently fails on iOS; see https://github.com/dotnet/maui/issues/19488")]
public void Issue10300Test()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.iOS },
"Currently fails on iOS; see https://github.com/dotnet/maui/issues/19488");

this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.Mac, TestDevice.Windows },
"iOS specific Test");

App.Click("Add");
App.Click("Delete");
App.WaitForElement("Close");
App.Click("Close");
App.WaitForNoElement("2");
}
}
}
}
#endif
4 changes: 2 additions & 2 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/CarouselViewUITests.SetOrientation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ public CarouselViewSetOrientation(TestDevice device)
// Issue12193 (src\ControlGallery\src\Issues.Shared\Issue12193.cs
[Test]
[Category(UITestCategories.CarouselView)]
[FailsOnMac("Set Orientation methods not implemented")]
[FailsOnWindows("Set Orientation methods not implemented")]
public async Task RotatingCarouselViewHTMLShouldNotDisappear()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Mac, TestDevice.Windows });

int delay = 3000;

App.SetOrientationPortrait();
Expand Down
8 changes: 3 additions & 5 deletions ...ntrols/tests/TestCases.Shared.Tests/Tests/Issues/CarouselViewUITests.UpdateCurrentItem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Microsoft.Maui.TestCases.Tests;
#if ANDROID
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;
Expand All @@ -19,13 +19,11 @@ public CarouselViewUpdateCurrentItem(TestDevice device)
[Category(UITestCategories.CarouselView)]
public void Issue9827Test()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.iOS, TestDevice.Mac, TestDevice.Windows },
"Android specific Test");

App.WaitForNoElement("Pos:0");
App.Click("btnNext");
App.WaitForNoElement("Item 1 with some additional text");
App.WaitForNoElement("Pos:1");
}
}
}
}
#endif
9 changes: 4 additions & 5 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/CarouselViewUITests.UpdatePosition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using NUnit.Framework;
#if ANDROID
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

Expand All @@ -18,13 +19,11 @@ public CarouselViewUpdatePosition(TestDevice device)
[Category(UITestCategories.CarouselView)]
public void CarouselViewPositionFromVisibilityChangeTest()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.iOS, TestDevice.Mac, TestDevice.Windows },
"Android specific Test");

App.WaitForElement("AppearButton");
App.Click("AppearButton");
App.WaitForNoElement("Item 4");
App.Screenshot("Success");
}
}
}
}
#endif
6 changes: 3 additions & 3 deletions ...ls/tests/TestCases.Shared.Tests/Tests/Issues/CollectionViewUITests.ClearGroupedNoCrash.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#if ANDROID
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;
Expand All @@ -22,12 +23,11 @@ public ClearGroupedNoCrashUITests(TestDevice device)
[Category(UITestCategories.CollectionView)]
public void ClearingGroupedNoCrash()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.iOS, TestDevice.Mac, TestDevice.Windows });

App.WaitForElement(Go);
App.Click(Go);

App.WaitForNoElement(Success);
}
}
}
}
#endif
4 changes: 2 additions & 2 deletions .../TestCases.Shared.Tests/Tests/Issues/CollectionViewUITests.CollectionViewBindingErrors.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ public CollectionViewBindingErrorsUITests(TestDevice device)
// CollectionViewBindingErrorsShouldBeZero (src\Compatibility\ControlGallery\src\Issues.Shared\CollectionViewBindingErrors.xaml.cs)
[Test]
[Category(UITestCategories.CollectionView)]
[FailsOnMac("This test is failing, likely due to product issue")]
[FailsOnWindows("This test is failing, likely due to product issue")]
public void NoBindingErrors()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Mac, TestDevice.Windows });

App.WaitForElement("WaitForStubControl");
App.WaitForNoElement("Binding Errors: 0");
}
Expand Down
6 changes: 2 additions & 4 deletions ....Shared.Tests/Tests/Issues/CollectionViewUITests.CollectionViewItemsUpdatingScrollMode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,9 @@ public void KeepItemsInView()
// KeepScrollOffset (src\Compatibility\ControlGallery\src\Issues.Shared\CollectionViewItemsUpdatingScrollMode.cs)
[Test]
[Category(UITestCategories.CollectionView)]
[FailsOnAllPlatforms("This test is failing, likely due to product issue")]
public void KeepScrollOffset()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.iOS, TestDevice.Mac, TestDevice.Windows });

App.WaitForElement("SelectScrollMode");
App.Click("SelectScrollMode");
App.Click("KeepScrollOffset");
Expand All @@ -64,10 +63,9 @@ public void KeepScrollOffset()
// KeepLastItemInView(src\Compatibility\ControlGallery\src\Issues.Shared\CollectionViewItemsUpdatingScrollMode.cs)
[Test]
[Category(UITestCategories.CollectionView)]
[FailsOnAllPlatforms("This test is failing, likely due to product issue")]
public void KeepLastItemInView()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.iOS, TestDevice.Mac, TestDevice.Windows });

App.WaitForElement("SelectScrollMode");
App.Click("SelectScrollMode");
App.Click("KeepLastItemInView");
Expand Down
10 changes: 2 additions & 8 deletions ...sts/TestCases.Shared.Tests/Tests/Issues/CollectionViewUITests.CollectionViewTabbedPage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,10 @@ public CollectionViewTabbedPageUITests(TestDevice device)

// AddingGroupToUnviewedGroupedCollectionViewShouldNotCrash (src\Compatibility\ControlGallery\src\Issues.Shared\Issue7700.cs)
[Test]
[Ignore("Click does not find Tab elements")]
[FailsOnAllPlatforms("Click does not find Tab elements")]
[Category(UITestCategories.CollectionView)]
public void AddingItemToUnviewedCollectionViewShouldNotCrash()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.iOS, TestDevice.Mac, TestDevice.Windows },
"Click does not find Tab elements");

App.WaitForElement(Add1);
App.Click(Add1);
App.Click(Tab2);
Expand All @@ -38,13 +35,10 @@ public void AddingItemToUnviewedCollectionViewShouldNotCrash()

// AddingGroupToUnviewedGroupedCollectionViewShouldNotCrash (src\Compatibility\ControlGallery\src\Issues.Shared\Issue7700.cs)
[Test]
[Ignore("Click does not find Tab elements")]
[FailsOnAllPlatforms("Click does not find Tab elements")]
[Category(UITestCategories.CollectionView)]
public void AddingGroupToUnviewedGroupedCollectionViewShouldNotCrash()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.iOS, TestDevice.Mac, TestDevice.Windows },
"Click does not find Tab elements");

App.WaitForElement(Add2);
App.Click(Add2);
App.Click(Tab3);
Expand Down
3 changes: 1 addition & 2 deletions ...ntrols/tests/TestCases.Shared.Tests/Tests/Issues/CollectionViewUITests.DynamicallyLoad.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,9 @@ public CollectionViewDynamicallyLoadUITests(TestDevice device)
// CollectionViewShouldSourceShouldUpdateWhileInvisible (src\Compatibility\ControlGallery\src\Issues.Shared\Issue13126.cs)
[Test]
[Category(UITestCategories.CollectionView)]
[FailsOnWindows("This test is failing, likely due to product issue")]
public void DynamicallyLoadCollectionView()
{
this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Windows });

App.WaitForNoElement(Success);
}
}
Expand Down
Loading
Loading