Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Bump xcode 15.4.0 #22611

Merged
merged 2 commits into from
Jul 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 5 additions & 14 deletions eng/pipelines/common/device-tests-steps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,10 @@ parameters:
checkoutDirectory: $(System.DefaultWorkingDirectory)
useArtifacts: false
rebootAgent: true
poolName: 'Azure Pipelines'

steps:
- ${{ if eq(parameters.platform, 'ios')}}:
- ${{ if and(eq(parameters.platform, 'ios'), ne(parameters.poolName, 'Azure Pipelines')) }}:
- bash: |
chmod +x $(System.DefaultWorkingDirectory)/eng/scripts/clean-bot.sh
chmod +x $(System.DefaultWorkingDirectory)/eng/scripts/clean-simulator-runtime.sh
Expand All @@ -29,9 +30,8 @@ steps:
platform: macos
skipXcode: ${{ or(eq(parameters.platform, 'android'), eq(parameters.platform, 'windows')) }}
skipProvisioning: ${{ eq(parameters.platform, 'windows') }}
${{ if eq(parameters.platform, 'ios')}}:
skipAndroidSdks: false
skipAndroidImages: true
skipAndroidImages : ${{ eq(parameters.platform, 'ios') }}
skipAndroidSdks: ${{ eq(parameters.platform, 'ios') }}
provisionatorChannel: ${{ parameters.provisionatorChannel }}

- pwsh: ./build.ps1 --target=dotnet --configuration="Release" --verbosity=diagnostic
Expand Down Expand Up @@ -120,15 +120,6 @@ steps:
condition: always()
continueOnError: true


- ${{ if eq(parameters.platform, 'ios')}}:
- bash: |
zip -9r "$(LogDirectory)/CoreSimulatorLog.zip" "$HOME/Library/Logs/CoreSimulator/"
zip -9r "$(LogDirectory)/DiagnosticReports.zip" "$HOME/Library/Logs/DiagnosticReports/"
displayName: Zip Simulator Logs
condition: always()
continueOnError: true

- task: PublishTestResults@2
displayName: Publish the $(Agent.JobName) test results
condition: always()
Expand All @@ -143,7 +134,7 @@ steps:
inputs:
artifactName: '$(Agent.JobName) (attempt $(System.JobAttempt))'

- ${{ if eq(parameters.rebootAgent, true) }}:
- ${{ if and(eq(parameters.platform, 'ios'), ne(parameters.poolName, 'Azure Pipelines')) }}:
# This must always be placed as the last step in the job
- template: agent-rebooter/mac.v1.yml@yaml-templates
parameters:
Expand Down
4 changes: 4 additions & 0 deletions eng/pipelines/common/device-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ stages:
artifactItemPattern: ${{ parameters.artifactItemPattern }}
checkoutDirectory: ${{ parameters.checkoutDirectory }}
useArtifacts: ${{ parameters.useArtifacts }}
poolName: ${{ parameters.androidPool.name }}

- stage: ios_device_tests
displayName: iOS Device Tests
Expand Down Expand Up @@ -102,6 +103,7 @@ stages:
artifactItemPattern: ${{ parameters.artifactItemPattern }}
checkoutDirectory: ${{ parameters.checkoutDirectory }}
useArtifacts: ${{ parameters.useArtifacts }}
poolName: 'Azure Pipelines'

- stage: catalyst_device_tests
displayName: macOS Device Tests
Expand Down Expand Up @@ -141,6 +143,8 @@ stages:
artifactItemPattern: ${{ parameters.artifactItemPattern }}
checkoutDirectory: ${{ parameters.checkoutDirectory }}
useArtifacts: ${{ parameters.useArtifacts }}
poolName: 'Azure Pipelines'


- stage: windows_device_tests
displayName: Windows Device Tests
Expand Down
6 changes: 3 additions & 3 deletions eng/pipelines/common/maui-templates.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,14 @@ parameters:
- name: $(androidTestsVmPool)
vmImage: $(androidTestsVmImage)
demands:
- macOS.Name -equals Ventura
- macOS.Name -equals Sonoma
- macOS.Architecture -equals x64
testName: RunOnAndroid
artifact: templates-run-android
- name: $(iosTestsVmPool)
vmImage: $(iosTestsVmImage)
demands:
- macOS.Name -equals Ventura
- macOS.Name -equals Sonoma
- macOS.Architecture -equals x64
testName: RunOniOS
artifact: templates-run-ios
Expand Down Expand Up @@ -71,7 +71,7 @@ jobs:
name: $(POOL_NAME)
vmImage: $(POOL_VIMAGE)
demands:
- macOS.Name -equals Ventura
- macOS.Name -equals Sonoma
- macOS.Architecture -equals x64
steps:

Expand Down
31 changes: 10 additions & 21 deletions eng/pipelines/common/provision.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,15 @@ parameters:

steps:
# Prepare macOS
- template: agent-cleanser/v1.yml@yaml-templates
parameters:
condition: and(succeeded(), eq(variables['Agent.OS'], 'Darwin'))
UninstallMono: false
UninstallXamarinMac: false
CleanseAgentToolsDotNet: true # Cleanse all .NET versions under the agent tools directory and use only those provisioned by the pipeline
SelfHealPowerShell: false
AUTH_TOKEN_GITHUB_COM: $(github--pat--vs-mobiletools-engineering-service2)
- ${{ if ne(parameters.poolName, 'Azure Pipelines') }}:
- template: agent-cleanser/v1.yml@yaml-templates
parameters:
condition: and(succeeded(), eq(variables['Agent.OS'], 'Darwin'))
UninstallMono: false
UninstallXamarinMac: false
CleanseAgentToolsDotNet: true # Cleanse all .NET versions under the agent tools directory and use only those provisioned by the pipeline
SelfHealPowerShell: false
AUTH_TOKEN_GITHUB_COM: $(github--pat--vs-mobiletools-engineering-service2)
# Provision Xcode
- ${{ if ne(parameters.skipXcode, 'true') }}:
- task: xamops.azdevex.provisionator-task.provisionator@2
Expand Down Expand Up @@ -147,16 +148,4 @@ steps:
filePath: $(System.DefaultWorkingDirectory)/eng/common/SetupNugetSources.ps1
arguments: -ConfigFile $(System.DefaultWorkingDirectory)/NuGet.config -Password $Env:Token
env:
Token: $(dn-bot-dnceng-artifact-feeds-rw)
# Prepare for Reunion packages
# - ${{ if eq(variables['System.TeamProject'], 'devdiv') }}:
# - task: NuGetAuthenticate@0
# displayName: 'Authenticate Reunion NuGet sources'
# inputs:
# nuGetServiceConnections: Project.Reunion.nuget.internal
# - pwsh: |
# $path = '$(Build.SourcesDirectory)\NuGet.config'
# [xml]$xml = Get-Content $path
# $xml.configuration.RemoveChild($xml.configuration.disabledPackageSources)
# $xml.Save($path)
# displayName: 'Add "wasdk-internal" to NuGet.config'
Token: $(dn-bot-dnceng-artifact-feeds-rw)
4 changes: 2 additions & 2 deletions eng/pipelines/common/variables.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ variables:
- name: DOTNET_VERSION
value: 8.0.300
- name: REQUIRED_XCODE
value: 15.2.0
value: 15.4.0
- name: DEVICETESTS_REQUIRED_XCODE
value: 15.2.0
value: 15.4.0
- name: LocBranchPrefix
value: 'loc-hb'
- name: isMainBranch
Expand Down
9 changes: 3 additions & 6 deletions eng/pipelines/device-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,17 +69,14 @@ parameters:
- name: iosPool
type: object
default:
name: $(iosTestsVmPool)
vmImage: $(iosTestsVmImage)
demands:
- macOS.Name -equals Ventura
- macOS.Architecture -equals x64
name: $(macosTestsVmPool)
vmImage: macOS-14

- name: catalystPool
type: object
default:
name: $(macosTestsVmPool)
vmImage: $(macosTestsVmImage)
vmImage: macOS-14

- name: windowsPool
type: object
Expand Down
10 changes: 5 additions & 5 deletions eng/pipelines/handlers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -101,14 +101,14 @@ parameters:
- name: $(androidTestsVmPool)
vmImage: $(androidTestsVmImage)
demands:
- macOS.Name -equals Ventura
- macOS.Name -equals Sonoma
- macOS.Architecture -equals x64
testName: RunOnAndroid
artifact: templates-run-android
- name: $(iosTestsVmPool)
vmImage: $(iosTestsVmImage)
demands:
- macOS.Name -equals Ventura
- macOS.Name -equals Sonoma
- macOS.Architecture -equals x64
testName: RunOniOS
artifact: templates-run-ios
Expand Down Expand Up @@ -155,7 +155,7 @@ stages:
name: ${{ BuildPlatform.poolName }}
vmImage: ${{ BuildPlatform.vmImage }}
demands:
- macOS.Name -equals Ventura
- macOS.Name -equals Sonoma
- macOS.Architecture -equals x64
steps:
- template: common/provision.yml
Expand Down Expand Up @@ -197,7 +197,7 @@ stages:
name: ${{ PackPlatform.poolName }}
vmImage: ${{ PackPlatform.vmImage }}
demands:
- macOS.Name -equals Ventura
- macOS.Name -equals Sonoma
- macOS.Architecture -equals x64
variables:
- name: _buildScript
Expand Down Expand Up @@ -245,7 +245,7 @@ stages:
name: ${{ BuildPlatform.poolName }}
vmImage: ${{ BuildPlatform.vmImage }}
demands:
- macOS.Name -equals Ventura
- macOS.Name -equals Sonoma
- macOS.Architecture -equals x64
steps:
- template: common/provision.yml
Expand Down
10 changes: 5 additions & 5 deletions eng/pipelines/ui-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ parameters:
name: $(androidTestsVmPool)
vmImage: $(androidTestsVmImage)
demands:
- macOS.Name -equals Ventura
- macOS.Name -equals Sonoma
- macOS.Architecture -equals x64

- name: iosPool
Expand All @@ -76,7 +76,7 @@ parameters:
name: $(iosTestsVmPool)
vmImage: $(iosTestsVmImage)
demands:
- macOS.Name -equals Ventura
- macOS.Name -equals Sonoma
- macOS.Architecture -equals x64

- name: windowsPool
Expand All @@ -89,15 +89,15 @@ parameters:
type: object
default:
name: $(macosTestsVmPool)
vmImage: $(macosTestsVmImage)
vmImage: macOS-14

- name: androidCompatibilityPool
type: object
default:
name: $(androidTestsVmPool)
vmImage: $(androidTestsVmImage)
demands:
- macOS.Name -equals Ventura
- macOS.Name -equals Sonoma
- macOS.Architecture -equals x64

- name: iosCompatibilityPool
Expand All @@ -106,7 +106,7 @@ parameters:
name: $(androidTestsVmPool)
vmImage: $(androidTestsVmImage)
demands:
- macOS.Name -equals Ventura
- macOS.Name -equals Sonoma
- macOS.Architecture -equals x64

resources:
Expand Down
Loading