Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Subscribe less pointer events in UpdatingGestureRecognizers #22781

Merged
merged 2 commits into from
Jun 5, 2024
Merged

[Windows] Subscribe less pointer events in UpdatingGestureRecognizers #22781

merged 2 commits into from
Jun 5, 2024

Conversation

MartyIX
Copy link
Contributor

@MartyIX MartyIX commented Jun 1, 2024

Description of Change

The idea of the PR is simple. There two sets of pointer event subscriptions:

maui/src/Controls/src/Core/Platform/GestureManager/GesturePlatformManager.Windows.cs

Lines 792 to 796 in fcabff1

_container.PointerEntered += OnPgrPointerEntered;
_container.PointerExited += OnPgrPointerExited;
_container.PointerMoved += OnPgrPointerMoved;
_container.PointerPressed += OnPgrPointerPressed;
_container.PointerReleased += OnPgrPointerReleased;

and

maui/src/Controls/src/Core/Platform/GestureManager/GesturePlatformManager.Windows.cs

Lines 824 to 827 in fcabff1

_container.PointerPressed += OnPointerPressed;
_container.PointerExited += OnPointerExited;
_container.PointerReleased += OnPointerReleased;
_container.PointerCanceled += OnPointerCanceled;

Consequently, _container.PointerPressed, _container.PointerExited, and _container.PointerReleased are subscribed twice. And this PR removes these subscriptions.

Performance impact

image

-> ~25% improvement

Issues Fixed

Contributes to #21787

@MartyIX MartyIX requested a review from a team as a code owner June 1, 2024 20:45
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jun 1, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hey there @MartyIX! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@MartyIX MartyIX requested review from Foda and removed request for tj-devel709 June 2, 2024 08:59
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@Foda Foda merged commit 4a3bc31 into dotnet:main Jun 5, 2024
49 checks passed
@MartyIX MartyIX deleted the feature/2024-06-01-WinUI-pointers-perf branch June 5, 2024 22:29
@MartyIX MartyIX mentioned this pull request Jun 27, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz jsuarezruiz is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@Foda Foda Awaiting requested review from Foda

Assignees
No one assigned
Labels
area-gestures Gesture types community ✨ Community Contribution fixed-in-8.0.60 fixed-in-9.0.0-preview.6.24327.7 platform/windows 🪟
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MartyIX @jsuarezruiz @rmarinho @Foda @samhouts