-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt chromium methodology for determining tablet on Windows #22809
Conversation
Hey there @daltzctr! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
@dotnet-policy-service agree [company="CTR Electronics"] |
@dotnet-policy-service agree company="CTR Electronics" |
Marking as draft until I confirm a device that is Windows that should be tablet is still tablet (I will test on my Surface Pro 7). Reviews are still welcome. |
This is ready for review and/or merge. |
Can you share what device was wrong before (using stable MAUI)? Was it a Windows laptop that just always returned |
XPS 15 reports as tablet. |
Can this get merged? |
@Foda is this blocked on something? |
@Foda just a courtesy ping |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on being a .NET MAUI contributor!
Description of Change
Uses a more conservative approach of determining tablet mode on Windows. This approach is functionally identical to Chromium's implementation for determining tablet on Windows. Additionally, it adds a few documentation comments on the observed behavior.
I don't have a good idea on how to add a unit test for this, and it's a bit of an implicit breaking change (some users who had tablet layouts may have desktop layouts now), but I think that number of users affected will be near, or at 0.
Issues Fixed
Possibly fixes #22093