Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[X] Dont SetBinding for values returned by OnIdiom #23272

Closed
wants to merge 2 commits into from
Closed

[X] Dont SetBinding for values returned by OnIdiom #23272

wants to merge 2 commits into from

Conversation

StephaneDelcroix
Copy link
Contributor

Description of Change

align debug behavior with compiled one. OnIdiom doesn't tell the compiler the type returned, so it can't Setbinding

Issues Fixed

@StephaneDelcroix StephaneDelcroix requested a review from a team as a code owner June 26, 2024 13:03
@PureWeen PureWeen added the area-xaml XAML, CSS, Triggers, Behaviors label Jun 27, 2024
@PureWeen
Copy link
Member

PureWeen commented Aug 9, 2024

/rebase

@StephaneDelcroix @PureWeen
[X] Dont SetBinding for values returned by OnIdiom
bf1e661 
align debug behavior with compiled one. OnIdiom doesn't tell the
compiler the type returned, so it can't Setbinding

- fixes #18697
- fixes #22877
@StephaneDelcroix @PureWeen
avoid NRE
9e818a0
PureWeen
PureWeen requested changes Aug 13, 2024
View reviewed changes
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test to this one?

@StephaneDelcroix
Copy link
Contributor Author

alternate option, which might be better, would be to redirect SetValue(BindingBase binding) to SetBinding...

trying to see if it's a viable solution...

StephaneDelcroix added a commit that referenced this pull request Sep 4, 2024
@StephaneDelcroix
[C] Allow OnIdiom/OnPlatform to return a Binding
57b8365 
- fixes #19388
- fixes #18697
- closes #23798
- closes #23272

and some others
@StephaneDelcroix StephaneDelcroix mentioned this pull request Sep 4, 2024
Merged
StephaneDelcroix added a commit that referenced this pull request Sep 4, 2024
@StephaneDelcroix
[C] Allow OnIdiom/OnPlatform to return a Binding
2d899a2 
- fixes #19388
- fixes #18697
- fixes #22877
- closes #23798
- closes #23272

and some others
@StephaneDelcroix StephaneDelcroix added the do-not-merge Don't merge this PR label Sep 10, 2024
@PureWeen PureWeen closed this in 9a78453 Sep 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PureWeen PureWeen PureWeen requested changes

@Eilon Eilon Awaiting requested review from Eilon Eilon is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz jsuarezruiz is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-xaml XAML, CSS, Triggers, Behaviors do-not-merge Don't merge this PR
Projects
None yet
Milestone
No milestone
2 participants
@StephaneDelcroix @PureWeen