Skip to content

Conversation

@kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Jun 28, 2024

Issues Fixed

Fixes #23325
Fixes #24100

@kubaflo kubaflo requested a review from a team as a code owner June 28, 2024 22:42
@dotnet-policy-service
Copy link
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jun 28, 2024
@Redth
Copy link
Member

Redth commented Jul 10, 2024

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@mattleibow
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

mattleibow
mattleibow previously approved these changes Jul 18, 2024
@PureWeen
Copy link
Member

PureWeen commented Aug 3, 2024

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@samhouts samhouts added the area-controls-shell Shell Navigation, Routes, Tabs, Flyout label Aug 29, 2024
@aheubusch
Copy link
Contributor

@kubaflo @PureWeen I think I see another bug. Once a custom BackgroundColor has been set its not possible to return to the default color (searchHandler.BackgroundColor = null;). Infact it will cause a NRE in line 168 (backGroundColor.ToPlatform()).
Proposed change to line 154

if (backGroundColor == null)
{
	_hasCustomBackground = false;
	
	backgroundView.Layer.CornerRadius = 0;
	backgroundView.ClipsToBounds = false;
	backgroundView.BackgroundColor = _defaultBackgroundColor;
	textField.BackgroundColor = _defaultBackgroundColor;
	
	return;
}

@jsuarezruiz
Copy link
Contributor

/rebase

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/rebase

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@kubaflo kubaflo self-assigned this Mar 10, 2025
@mattleibow
Copy link
Member

/rebase

Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kubaflo not sure if you had thoughts or observed exceptions when setting back to null?

#23355 (comment)

That is technically a separate issue and you have probs fixed it already :)

@PureWeen PureWeen changed the base branch from main to inflight/current May 13, 2025 22:37
@PureWeen PureWeen merged commit 37e57ea into dotnet:inflight/current May 13, 2025
1 check passed
PureWeen pushed a commit that referenced this pull request May 14, 2025
* [iOS] Setting background color on the Searchbar (#23325)

* Added a test category

* Ui tests

* Update SearchHandlerAppearanceTracker.cs

* Update Issue23325Test.png
github-actions bot pushed a commit that referenced this pull request May 15, 2025
* [iOS] Setting background color on the Searchbar (#23325)

* Added a test category

* Ui tests

* Update SearchHandlerAppearanceTracker.cs

* Update Issue23325Test.png
PureWeen pushed a commit that referenced this pull request May 21, 2025
* [iOS] Setting background color on the Searchbar (#23325)

* Added a test category

* Ui tests

* Update SearchHandlerAppearanceTracker.cs

* Update Issue23325Test.png
PureWeen pushed a commit that referenced this pull request May 21, 2025
* [iOS] Setting background color on the Searchbar (#23325)

* Added a test category

* Ui tests

* Update SearchHandlerAppearanceTracker.cs

* Update Issue23325Test.png
github-actions bot pushed a commit that referenced this pull request May 22, 2025
* [iOS] Setting background color on the Searchbar (#23325)

* Added a test category

* Ui tests

* Update SearchHandlerAppearanceTracker.cs

* Update Issue23325Test.png
github-actions bot pushed a commit that referenced this pull request May 30, 2025
* [iOS] Setting background color on the Searchbar (#23325)

* Added a test category

* Ui tests

* Update SearchHandlerAppearanceTracker.cs

* Update Issue23325Test.png
github-actions bot pushed a commit that referenced this pull request May 30, 2025
* [iOS] Setting background color on the Searchbar (#23325)

* Added a test category

* Ui tests

* Update SearchHandlerAppearanceTracker.cs

* Update Issue23325Test.png
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-shell Shell Navigation, Routes, Tabs, Flyout community ✨ Community Contribution platform/ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting background color on the Searchbar does nothing on iOS Initial value for the SearchHandler background color ignored on page first appearance

10 participants