Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing UI Test category to fix main build #23428

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

jfversluis
Copy link
Member

Description of Change

#23287 adds an analyzer for missing [Category] attributes but #22345 just missed that one, this fixes the build

cc: @kubaflo make sure to add categories to UI tests now, also for existing PRs!

@jfversluis jfversluis requested a review from a team as a code owner July 4, 2024 12:56
@jfversluis jfversluis changed the title Add missing UI Test category Add missing UI Test category to fix main buils Jul 4, 2024
@jfversluis jfversluis changed the title Add missing UI Test category to fix main buils Add missing UI Test category to fix main build Jul 4, 2024
kubaflo added a commit to kubaflo/maui that referenced this pull request Jul 4, 2024
@jfversluis jfversluis enabled auto-merge (squash) July 4, 2024 13:52
@jfversluis jfversluis added the area-testing Unit tests, device tests label Jul 4, 2024
@PureWeen PureWeen merged commit b5ee5fc into main Jul 4, 2024
41 of 47 checks passed
@PureWeen PureWeen deleted the fix-build-uitestcat branch July 4, 2024 14:27
github-actions bot pushed a commit to kubaflo/maui that referenced this pull request Jul 4, 2024
github-actions bot pushed a commit to kubaflo/maui that referenced this pull request Jul 5, 2024
github-actions bot pushed a commit to kubaflo/maui that referenced this pull request Jul 5, 2024
PureWeen added a commit that referenced this pull request Jul 5, 2024
* [iOS] Crash upon resuming the app - fix (#21948)

* Refactor

* Update UIApplicationExtensions.cs

* Update UIApplicationExtensions.cs

* Update UIApplicationExtensions.cs

* Added a UI test (#21948)

* Added a test category (#23428)

* remove "'"

---------

Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
@samhouts samhouts added fixed-in-8.0.70 fixed-in-net9.0-nightly This may be available in a nightly release! labels Aug 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing Unit tests, device tests fixed-in-8.0.70 fixed-in-net9.0-nightly This may be available in a nightly release! t/housekeeping ♻︎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants