Do not solely make Visual Diagnostics available on debugger being attached #23490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| @@ -13,16 +13,19 @@ namespace Microsoft.Maui | |||
| public static class VisualDiagnostics | |||
| { | |||
| static ConditionalWeakTable<object, SourceInfo> sourceInfos = new ConditionalWeakTable<object, SourceInfo>(); | |||
| static Lazy<bool> isVisualDiagnosticsEnvVarSet = new Lazy<bool>(() => Environment.GetEnvironmentVariable("ENABLE_XAML_DIAGNOSTICS_SOURCE_INFO") is { } value && value == "1"); | |||
|
|
|||
| static public bool IsEnabled => DebuggerHelper.DebuggerIsAttached || isVisualDiagnosticsEnvVarSet.Value; | |||
There was a problem hiding this comment.
Does this need to be a public variable? Since it's not settable and not used outside of this repo I'm not sure if it's needed to be accessible.
There was a problem hiding this comment.
Good point! It should be internalvisible to Microsoft.Maui.Controls
chabiss
force-pushed
the
dev/chabiss/azdo_2078603
branch
from
db21032 to
5eaf90a
Compare
drasticactions
approved these changes
Jul 22, 2024
StephaneDelcroix
approved these changes
Jul 23, 2024
|
@StephaneDelcroix Indeed, I'm attempting to discern whether there's a difference from how things were prior to this PR. Are there still Debugger checks in the runtime XAML Parser that I might have overlooked or need to modify? |
samhouts
added
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This changes ensure that Visual Diagnostics doesn't rely on the debugger being attached, like the rest of the supported platforms (WPF, UWP, WinUI). Other platform relies on ENABLE_XAML_DIAGNOSTICS_SOURCE_INFO to be set by the Launch Provider in VS to enable Full Visual Diagnostics with Source Information. For backward compatibility, MAUI will still continue to check for the debugger being attached, but will also check the presence of the environment.
Issues Fixed
Task 2078603: Remove MAUI's VisualDiagnostics coupling on the Debugger