Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect MauiCALayer being rendered offscreen #23648

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

albyrock87
Copy link
Contributor

@albyrock87 albyrock87 commented Jul 17, 2024

Description of Change

If the super layer's frame is zero, indicating an off-screen rendering scenario, the bounds are intentionally kept at zero to avoid incorrect initial drawing caused by bounds matching the screen size.

Before fix
Simulator Screen Recording - iPhone 15 Pro Max - 2024-07-17 at 12 15 44

After fix

Simulator Screen Recording - iPhone 15 Pro Max - 2024-07-17 at 11 53 37

Issues Fixed

Fixes #23070

@albyrock87 albyrock87 requested a review from a team as a code owner July 17, 2024 10:16
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jul 17, 2024
@mattleibow
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen
Copy link
Member

Failing test unrelated

@PureWeen PureWeen merged commit a5a3e1e into dotnet:main Jul 17, 2024
95 of 97 checks passed
@samhouts samhouts added fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-8.0.80 and removed fixed-in-net9.0-nightly This may be available in a nightly release! labels Aug 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community ✨ Community Contribution fixed-in-8.0.80 fixed-in-net9.0-nightly This may be available in a nightly release!
Projects
None yet
4 participants