Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back ResourceDictionary.SetAndLoadSource #23683

Conversation

simonrozsival
Copy link
Member

Description of Change

We need to keep the ResourceDictionary.SetAndLoadSource method for XAML hot reload. The method can be internal.

/cc @StephaneDelcroix @spadapet

@simonrozsival simonrozsival added the area-xaml XAML, CSS, Triggers, Behaviors label Jul 18, 2024
@simonrozsival simonrozsival requested a review from a team as a code owner July 18, 2024 16:06
@spadapet spadapet added the partner/hot-reload-xaml Issues impacting XAML Hot Reload experiences label Jul 18, 2024
@spadapet
Copy link
Contributor

I tested this change with MAUI Full Page Hot Reload in Visual Studio, and it works!

@mattleibow mattleibow merged commit e1400c5 into dotnet:net9.0 Jul 23, 2024
111 checks passed
@samhouts samhouts added the fixed-in-net9.0-nightly This may be available in a nightly release! label Aug 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2024
@samhouts samhouts added the fixed-in-net8.0-nightly This may be available in a nightly release! label Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-xaml XAML, CSS, Triggers, Behaviors fixed-in-net8.0-nightly This may be available in a nightly release! fixed-in-net9.0-nightly This may be available in a nightly release! partner/hot-reload-xaml Issues impacting XAML Hot Reload experiences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants