[Binding SG] Use Binding.Create internally in MAUI #23722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrozsival
force-pushed
the
use-binding-create-in-product
branch
3 times, most recently
from
bbf57d9 to
cb80c71
Compare
simonrozsival
requested review from
PureWeen,
tj-devel709,
jonathanpeppers,
jkurdek and
StephaneDelcroix
jkurdek
previously approved these changes
Jul 24, 2024
jonathanpeppers
previously approved these changes
Jul 24, 2024
simonrozsival
force-pushed
the
use-binding-create-in-product
branch
from
628e441 to
d34016e
Compare
|
@rmarinho @jonathanpeppers @PureWeen the failing tests are unrelated to this PR. Could we merge this PR now? |
samhouts
added
the
fixed-in-net9.0-nightly
samhouts
added
the
fixed-in-net8.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR fixes several oversights in the initial PR that introduced the
Binding.Createmethod (#23239) that I found while dogfooding the new API:BindingtoBindingBase. This is necessary to avoid trim analyzer warnings, the[UnconditionalSuppressMessage]didn't work the way I originally thought it would. It is still possible to callBinding.Create(...)and this call will be intercepted.Besides the fixes, I replaces all the usages of
TypedBinding.ForSingleNestingLevelthat aren't used alongsideSetBindingwith the new API. TheForSingleNestingLevelmethod will be completely removed in a later PR.Issues Fixed
Contributes to #22384
Depends on #23393 -
needs rebasing after this PR is merged