[net9.0] [Windows] Add TitleBar Control #23845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Custom titlebar control support spike * handle titlebar hit test elements automatically * sample * Added TitleBar property to Window: you can now set titlebar properties on the Window such as leading + trailing content, color, etc. * Add inactive colors for background + foreground Fix hide/show titlebar control not working * Fix issue w/ titlebar unhook on window close Add titlebar to sample page * Added `Window.SetTitleBar` function to set the window titlebar. This allows XAML defined titlebars w/ bindings * Revert some changes * Revert changes Fix PublicAPI defs * Error checkAdditional error checks for page nav * Update ITitlebar interface * Titlebar control is now a TemplatedView * Remove `SetTitlebar` API Update sample * Remove child * Use pattern matching * Add some docs * Fix missing publicapi bits * More public api bits * Missed some * Fix use of content presenter * Adjust passthrough logic * Fix titlebar height adjust for caption buttons * Fix override of default template not working * Cleanup * Fix default control template not being applied Add default style for TitleBar * Fix missing API for tizen * Fix sample issue Update sample * Fix missing title + icon when titlebar is not fully set Fix titlebar title spacing w/ default behavior Fix titlebar content added not allowing hit test Fix missing public API * Add IgnoreSafeArea for macOS * Tizen * Fix titlebar being set on window creation w/ template selector * Comment out templates --------- Co-authored-by: Mike Corsaro <mikecorsaro@microsoft.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> # Conflicts: # src/Controls/src/Core/PublicAPI/net-android/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-tizen/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-windows/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/netstandard/PublicAPI.Unshipped.txt # src/Core/src/PublicAPI/net-tizen/PublicAPI.Unshipped.txt
PureWeen
approved these changes
Jul 26, 2024
|
By the way, when is this feature expected to be released? |
samhouts
added
the
fixed-in-net9.0-nightly
samhouts
added
the
fixed-in-net8.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Reland of #23019 but onto net9.0.
The main PR was reverted here: #23844