Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the 'Resources' prefix from BundleResource #23978

Merged
merged 5 commits into from
Aug 5, 2024
Merged

Conversation

mattleibow
Copy link
Member

@mattleibow mattleibow commented Aug 2, 2024

Description of Change

Prior to Maui 8.0.70, there was a bug that only removed the "Resources/" prefix, and not the correct "Platforms/iOS/Resources/": #16734

The PR #23269 fixes the original issue, but now exposed the case where @(BundleResource) were included in the root "Resources" folder instead of the "Platforms/iOS/Resources" folder.

Issues Fixed

Fixes #23554

@mattleibow mattleibow requested a review from a team as a code owner August 2, 2024 12:05
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a template-style test, that includes a @(BundleResource) of each type that should work?

jfversluis
jfversluis previously approved these changes Aug 5, 2024
rolfbjarne
rolfbjarne previously approved these changes Aug 5, 2024
@PureWeen
Copy link
Member

PureWeen commented Aug 5, 2024

/backport to release/8.0.1xx-sr7

Fixes #23554

Prior to Maui 8.0.70, there was a bug that only removed the "Resources/" prefix, and not the correct "Platforms/iOS/Resource": #16734

This PR #23269 fixes the original issue, but now exposed the case where BundleResource were included in the root Resources folder instead of the Platforms/iOS/ folder.
@mattleibow
Copy link
Member Author

#24015 succeeded and was merged.

@mattleibow mattleibow merged commit ad886be into main Aug 5, 2024
60 of 97 checks passed
@mattleibow mattleibow deleted the dev/fix-res branch August 5, 2024 20:52
@PureWeen
Copy link
Member

PureWeen commented Aug 5, 2024

/backport to release/9.0.1xx-preview7

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Started backporting to release/9.0.1xx-preview7: https://github.com/dotnet/maui/actions/runs/10257553522

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On IOS - After Updating new Package Microsoft.Maui.Controls-8.0.70 App is not Compiling
6 participants