Use explicit platform versions #23995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used to avoid the case where some SDKs bump their platform version and we end up forcing the entire ecosystem to update SDKs.
jonathanpeppers
approved these changes
Aug 5, 2024
Comment on lines
+136
to
+144
| <!-- Previous .NET --> | ||
| <IosPreviousTargetFrameworkVersion>16.1</IosPreviousTargetFrameworkVersion> | ||
| <TvosPreviousTargetFrameworkVersion>16.1</TvosPreviousTargetFrameworkVersion> | ||
| <MacCatalystPreviousTargetFrameworkVersion>16.1</MacCatalystPreviousTargetFrameworkVersion> | ||
| <MacosPreviousTargetFrameworkVersion>13.0</MacosPreviousTargetFrameworkVersion> | ||
| <AndroidPreviousTargetFrameworkVersion>33.0</AndroidPreviousTargetFrameworkVersion> | ||
| <WindowsPreviousTargetFrameworkVersion>10.0.19041.0</WindowsPreviousTargetFrameworkVersion> | ||
| <Windows2PreviousTargetFrameworkVersion>10.0.20348.0</Windows2PreviousTargetFrameworkVersion> | ||
| <TizenPreviousTargetFrameworkVersion>7.0</TizenPreviousTargetFrameworkVersion> |
There was a problem hiding this comment.
Are there some projects that use .NET 7? Can we get rid of those, and only target the current supported version? 7 support ended in May.
There was a problem hiding this comment.
Not sure, but I think that would be a breaking change? The current nugets have .NET 7 so I am not sure if we can remove net7.
There was a problem hiding this comment.
Seems we still have a lot of people using .net 7 since it still is in VS
PureWeen
approved these changes
Aug 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This is used to avoid the case where some SDKs bump their platform version and we end up forcing the entire ecosystem to update SDKs.
This just updates the library projects to use explicit versions, all the sample and tests apps still use the unversioned TFMs like a typical dev would.
This is an alternative to #23966 but makes sure to use the old versions for net7 and the new versions for net8.