[Android] Fix ToolbarItem font color issue after changing available state. #24065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Adding Tests in progress |
|
Tested referenced issues and this looks good Once we get a test let's merge it |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
reviewed
Aug 8, 2024
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue10660.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@dotnet-policy-service agree |
PureWeen
approved these changes
Aug 22, 2024
Redth
pushed a commit
that referenced
this pull request
Aug 22, 2024
…state. (#24065) * [Android] ToolbarItem font color issue. * Added UI Tests. * Modified the test case. * Updated the test cases. * Commit for test cases change * Modified the test samples. * Modified the test samples. * Images have been added. --------- Co-authored-by: Suthi <suthi.yuvaraj@syncfusion.com>
samhouts
added
fixed-in-net9.0-nightly
samhouts
added
fixed-in-9.0.0-rc.1.24453.9
and removed
fixed-in-net9.0-nightly
sheiksyedm
added
the
partner/syncfusion
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause:
UpdateMenuItemmethod from theOnToolbarItemPropertyChangedmethod. In UpdateMenuItem, if tintColor is null, the text is set to the title without applying any color. As a result, the text was set without the intended color.Description of Change:
BarTextColorto theOnToolbarItemPropertyChangedmethod instead ofnull, similar to how we update the value during initial loading in theUpdateMenumethod.Reference:
maui/src/Controls/src/Core/Toolbar/Toolbar.Android.cs
Line 70 in abf9283
Issues Fixed
Fixes #22937
Fixes #10660
Screenshots: