Ensure border stroke only updates when needed #24125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
approved these changes
Aug 9, 2024
jfversluis
approved these changes
Aug 10, 2024
samhouts
added
the
fixed-in-net8.0-nightly
samhouts
added
the
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure border stroke does not regenerate on Parent or Window property changes.
Description of Change
Don't raise a property changed event for
StrokeShapein theBorderobject when theStrokeShape.WindoworStrokeShape.Parentproperty change. These properties are modified when theBorderis added/removed from the visual tree and can cause significant performance issues for lists when they're unloaded.Using the sample on the linked issue:
Issues Fixed
Fixes #24123
Fixes #23992