Obsolete Compatibility.Layout #24342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
commented
Aug 20, 2024
rmarinho
reviewed
Aug 21, 2024
mattleibow
approved these changes
Aug 24, 2024
samhouts
added
the
fixed-in-net9.0-nightly
samhouts
added
the
fixed-in-net8.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR finishes out obsoleting Compatibility Layout so that we can remove it from the hierarchy of a number of controls (ScrollView/Page/ContentPresenter,SwipeView, etc..) in NET10.
Compatibility.LayoutInvalidateMeasuremethod. I realize this is somewhat scary giving people the power to use these, but, these are somewhat necessary APIs for a number of scenarios. Especially iOS where invalidations don't propagate up the tree naturally. They are also useful for scenarios where users are doing custom layouts.ForceLayoutis obsolete and they don't need to use it. I haven't generated the txt files for these yet until the team agrees