Fix border lagging and unwanted animations on iOS #24360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @albyrock87! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
MartyIX
reviewed
Aug 21, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
samhouts
added
the
area-drawing
Co-authored-by: MartyIX <203266+MartyIX@users.noreply.github.com>
albyrock87
force-pushed
the
fix-24014
branch
from
93697cd
to
72a0141
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Sep 6, 2024
samhouts
added
the
fixed-in-net9.0-nightly
samhouts
added
fixed-in-9.0.0-rc.2.24503.2
and removed
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes border animations by simply overriding the
AddAnimationmethod and make it a noop.We can therefore get rid of the
CATransactioncode and simply relay on the fact that our layers will not animate.I really hope this is the last time we fix this :D
Before
After
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-08-21.at.18.12.33.mp4
Issues Fixed
Fixes #24104
Fixes #21643 (confirmed #21643 (comment))
Fixes #23688 (confirmed #23688 (comment))