[Android] Fix item fading when moving between groups in Grouped CollectionView #24461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sults in the temporary fading out of two items instead of one on Android
|
Hey there @Vignesh-SF3580! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
Issue is related to animation, test case is not included. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Aug 27, 2024
samhouts
added
the
area-controls-collectionview
samhouts
added
fixed-in-net9.0-nightly
samhouts
added
fixed-in-9.0.0-rc.2.24503.2
and removed
fixed-in-net9.0-nightly
sheiksyedm
added
the
partner/syncfusion
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause
In the ObservableItemsSource class, the CollectionChanged event was directly removed in the Dispose method instead of using the WeakNotifyCollectionChangedProxy.Unsubscribe(). This caused incorrect event handling, leading to a visual glitch where both the selected and the next item temporarily faded in a grouped CollectionView on Android.
Description of Change
The fix involved correctly unsubscribing from the CollectionChanged event using WeakNotifyCollectionChangedProxy.Unsubscribe() in the Dispose method. This change ensures proper event handling, preventing unintended visual effects during item movements in a grouped CollectionView.
Reference
https://github.com/dotnet/maui/blob/main/src/Controls/src/Core/Handlers/Items/CarouselViewHandler.Windows.cs#L56
Issues Fixed
Fixes #23152
Fixes #21698
Fixes #23138
Output
Before
After: