Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove netPrevious TFMs from RC/GA #24488

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Remove netPrevious TFMs from RC/GA #24488

merged 1 commit into from
Sep 8, 2024

Conversation

mattleibow
Copy link
Member

Description of Change

This was a nice feature for previews, but now it is time to grow up and become a real boy!

@mattleibow mattleibow requested review from a team as code owners August 28, 2024 15:41
@mattleibow mattleibow requested review from Eilon and jfversluis and removed request for a team August 28, 2024 15:41
Eilon
Eilon previously approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@Eilon Eilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like that you've left in a switch to make it easier in the future.

@samhouts samhouts added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Aug 28, 2024
@mattleibow mattleibow force-pushed the dev/remove-net8-tfms branch from c1a3028 to 0793ffa Compare August 29, 2024 14:10
@mattleibow mattleibow added this to the 9.0-rc2 milestone Aug 29, 2024
@mattleibow mattleibow self-assigned this Aug 29, 2024
@mattleibow mattleibow force-pushed the dev/remove-net8-tfms branch 3 times, most recently from d6783fc to eeb9492 Compare August 29, 2024 16:25
@mattleibow mattleibow changed the base branch from release/9.0.1xx-rc1 to net9.0 August 29, 2024 16:25
@mattleibow mattleibow dismissed Eilon’s stale review August 29, 2024 16:25

The base branch was changed.

@mattleibow mattleibow force-pushed the dev/remove-net8-tfms branch from eeb9492 to 119869b Compare August 30, 2024 14:28
@mattleibow mattleibow requested a review from Redth September 4, 2024 20:19
@PureWeen PureWeen merged commit b7328ad into net9.0 Sep 8, 2024
121 checks passed
@PureWeen PureWeen deleted the dev/remove-net8-tfms branch September 8, 2024 17:45
@samhouts samhouts added the fixed-in-net9.0-nightly This may be available in a nightly release! label Sep 20, 2024
@PureWeen PureWeen mentioned this pull request Sep 23, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
@samhouts samhouts added the fixed-in-net8.0-nightly This may be available in a nightly release! label Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Redth Redth Redth approved these changes

@Eilon Eilon Eilon left review comments

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees

@mattleibow mattleibow

Labels
area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions fixed-in-net8.0-nightly This may be available in a nightly release! fixed-in-net9.0-nightly This may be available in a nightly release!
Projects
MAUI SDK Ongoing
Status: Done
Milestone
9.0-rc2
Development

Successfully merging this pull request may close these issues.
5 participants
@mattleibow @Eilon @Redth @PureWeen @samhouts