Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the Nested Entry View In A Frame Causes Crash #24543

Merged
merged 6 commits into from
Sep 10, 2024

Conversation

BagavathiPerumal
Copy link
Contributor

@BagavathiPerumal BagavathiPerumal commented Aug 30, 2024

Root cause

In the FrameRenderer class, the Dispose() method is called from the disconnect handler, where the child is disposed of. After that, the disconnect handler of EntryHandler.Android is called. Disposing of the child in the FrameRenderer class causes the child object to be inaccessible in the disconnect handler of EntryHandler.Android.

Description of Issue Fix

Removed the child dispose method from the FrameRenderer to prevent the ObjectDisposedException from occurring in the child disconnect handler

Issues Fixed

Fixes #15196
Fixes #22372

Screenshots

Before Issue Fix After Issue Fix
FrameIssue.mp4
FixedFrame.mp4

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Aug 30, 2024
Copy link
Contributor

Hey there @BagavathiPerumal! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@BagavathiPerumal BagavathiPerumal marked this pull request as ready for review September 10, 2024 09:24
@BagavathiPerumal BagavathiPerumal requested a review from a team as a code owner September 10, 2024 09:24
@jfversluis
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen
Copy link
Member

Failing tests are unrelated

@PureWeen PureWeen merged commit 64343f5 into dotnet:main Sep 10, 2024
85 of 91 checks passed
@samhouts samhouts added the fixed-in-net9.0-nightly This may be available in a nightly release! label Oct 1, 2024
@samhouts samhouts added fixed-in-9.0.0-rc.2.24503.2 and removed fixed-in-net9.0-nightly This may be available in a nightly release! labels Oct 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2024
@sheiksyedm sheiksyedm added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-entry Entry community ✨ Community Contribution fixed-in-9.0.0-rc.2.24503.2 partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrolling a TableView causes java.lang.IllegalArgumentException Nested Entry View In A Frame Causes Crash
6 participants