Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Testing] Split off HandlerDoesNotLeak.DatePicker into its own UI test #24585

Merged
merged 3 commits into from
Sep 9, 2024
Merged

[Testing] Split off HandlerDoesNotLeak.DatePicker into its own UI test #24585

merged 3 commits into from
Sep 9, 2024

Conversation

dustin-wojciechowski
Copy link
Contributor

@dustin-wojciechowski dustin-wojciechowski commented Sep 3, 2024 •
edited by samhouts
Loading

Description of Change

Split off HandlerDoesNotLeak.DatePicker into its own UI test.

Issues Fixed

fixes #24147

@dustin-wojciechowski dustin-wojciechowski added the area-testing Unit tests, device tests label Sep 3, 2024
@dustin-wojciechowski dustin-wojciechowski requested a review from a team as a code owner September 3, 2024 20:03
@dustin-wojciechowski
Changed RunMemoryTest to take in INavigation instead of NavigationPag…
b68dd7a 
…e, renamed Issue24147 to MemoryTests and changed it to take in Text from Entry to determine which Handler to use, Removed Issue22072 as that's now in MemoryTests
@dustin-wojciechowski
Renamed Issue24147 in Tests.Shared to MemoryTests, added methods to c…
f581748 
…heck DatePicker and WebView. Added automationids in HostApp MemoryTests
jonathanpeppers
jonathanpeppers reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we introduce a leak, what does the test failure look like? I'm not certain the test is "the same", if you revert this commit does it fail?

@PureWeen
Copy link
Member

PureWeen commented Sep 9, 2024

I'm going to go ahead and merge this for now

I realize we have some left over changes on here but we're getting a lot of failures right now on CI

We can adjust any findings in a follow up PR that will be incoming soon.

@PureWeen PureWeen merged commit 9d965cc into main Sep 9, 2024
97 checks passed
@PureWeen PureWeen deleted the handlerdoesnotleak-datepicker-uitest branch September 9, 2024 22:16
@samhouts samhouts added the fixed-in-net9.0-nightly This may be available in a nightly release! label Oct 1, 2024
@samhouts samhouts added fixed-in-9.0.0-rc.2.24503.2 and removed fixed-in-net9.0-nightly This may be available in a nightly release! labels Oct 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonathanpeppers jonathanpeppers jonathanpeppers left review comments

@PureWeen PureWeen PureWeen approved these changes

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz jsuarezruiz is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-testing Unit tests, device tests fixed-in-9.0.0-rc.2.24503.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Testing] HandlerDoesNotLeak.DatePicker
4 participants
@dustin-wojciechowski @PureWeen @jonathanpeppers @samhouts