Improve MauiFactory performance by avoiding reflection to get base classes #24775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tj-devel709
added
the
area-core-hosting
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
requested review from
jonathanpeppers
and removed request for
jfversluis
jonathanpeppers
previously approved these changes
Sep 17, 2024
PureWeen
previously approved these changes
Sep 20, 2024
auto-merge was automatically disabled
September 21, 2024 21:34
Head branch was pushed to by a user without write access
albyrock87
dismissed stale reviews from PureWeen and jonathanpeppers
via
c89a4e3
albyrock87
force-pushed
the
maui-factory-perf
branch
3 times, most recently
from
bb8e201
to
01281ff
Compare
albyrock87
force-pushed
the
maui-factory-perf
branch
from
01281ff
to
ffe3077
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Comment on lines
+383
to
+390
| new WarningsPerCode | ||
| { | ||
| Code = "IL2070", | ||
| Messages = new List<string> | ||
| { | ||
| "Microsoft.Maui.Hosting.Internal.MauiFactory.ServiceBaseTypesFactory(Type): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.Interfaces' in call to 'System.Type.GetInterfaces()'. The parameter '#0' of method 'Microsoft.Maui.Hosting.Internal.MauiFactory.ServiceBaseTypesFactory(Type)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.", | ||
| } | ||
| }, |
There was a problem hiding this comment.
We should have 0 trimmer warnings going forward in the net9.0 branch. Should we target net9.0 for this change instead?
Ideally, no new trimmer warnings are introduced, and this might be some side-effect of not using .NET 9.
|
Declined this PR because it completely changed in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
A minor improvement to a piece of code executed on every
ToHandlerorToPlatform.Speedscope Before
Speedscope After
Extra note
I had some code ready to cache the entire
Type=>ServiceDescriptor(s)and make this even faster, but it breaks a unit test which honestly I don't understand the purpose of:maui/src/Core/tests/UnitTests/Hosting/HostBuilderHandlerTests.cs
Lines 86 to 99 in 3de5be9