[XC] Add feature switch to enable compiling bindings with source #24924
Conversation
| => methodDef.Body.Instructions.Any(instruction => | ||
| instruction.OpCode == OpCodes.Newobj | ||
| && instruction.Operand is MethodReference methodRef | ||
| && methodRef.DeclaringType.Name == "TypedBinding`2"); |
There was a problem hiding this comment.
Would the 2 change if a new type was introduced? Would this be more future proof?
| && methodRef.DeclaringType.Name == "TypedBinding`2"); | |
| && methodRef.DeclaringType.Name.StartsWith("TypedBinding`")); |
There was a problem hiding this comment.
I don't see why we would change TypedBinding to have a different number of generic arguments. It hasn't changed in a long time and it is (internal) public API. I would personally keep the test as is for now.
| @@ -175,6 +175,7 @@ | |||
| DebugSymbols = "$(DebugSymbols)" | |||
| DebugType = "$(DebugType)" | |||
| DefaultCompile = "true" | |||
| CompileBindingsWithSource = "$(MauiEnableXamlCBindingWithSourceCompilation)" | |||
There was a problem hiding this comment.
changing the API will cause problems and force clean/rebuild while changing version, but there's nothing we can do about it
There was a problem hiding this comment.
I think this is OK since this should be part of RC2 and not a servicing release. Maybe it would be worth mentioning in release notes?
simonrozsival
dismissed stale reviews from StephaneDelcroix and jonathanpeppers
via
c636600
|
do we need to highlight this as a compatibility change? |
This used to be a breaking change that wasn't fully documented. This PR ensures that users maintain more compatibility now when going from net8 to net9. Users can now only enable this path via a feature switch. @simonrozsival and @davidbritch are working on notes related to this and NativeAOT |
samhouts
added
the
fixed-in-net9.0-nightly
Description of Change
This PR adds a new feature switch
IsXamlCBindingWithSourceCompilationEnabledwhich is disabled by default unless the app is built with<PublishAot>true</PublishAot>or with<TrimMode>full</TrimMode>.This feature switch should make it easier to migrate existing apps to .NET 9. In some apps, bindings that previously worked would now stop working (see #23711 for customer feedback).
To make it possible to enable this feature by default in the future, I added a new warning
XC0025that will be shown by XamlC for all bindings that are not compiled because this feature is disabled.I also modified the error message when there is a mismatch between the declared x:DataType and the actual binding context. This is based on feedback in #24349. The error message will now contain the actual conflicting types and it should help developers identify which binding is failing more easily. I also added this warning to
TypedBindingwhich also rejects inputs that don't match the expected source type. This change should make it easier to enable the new feature switch in existing apps or when migrating to NativeAOT/full trimming./cc @jonathanpeppers @StephaneDelcroix @PureWeen @vitek-karas
Issues Fixed
Fixes #23711
Fixes #24349