Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and verify shadow / shape / clip #24941

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

albyrock87
Copy link
Contributor

@albyrock87 albyrock87 commented Sep 26, 2024

Description of Change

I'm creating a complex UI test to verify how shadow / shape / clip work on different platforms.

Right now the situation is a bit messed up:
image

Issues Fixed

@albyrock87 albyrock87 requested a review from a team as a code owner September 26, 2024 10:54
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Sep 26, 2024
@albyrock87
Copy link
Contributor Author

I need /AZP to collect screenshots on all platforms.

@PureWeen
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho rmarinho added this to the .NET 8 SR9 milestone Sep 27, 2024
@albyrock87
Copy link
Contributor Author

Current behavior of clipping / shadow / shape is completely messed up on different platform, I'm moving this to Draft.

image

@albyrock87 albyrock87 marked this pull request as draft September 28, 2024 15:03
@albyrock87 albyrock87 changed the title Fix shadow invalidation on Android Fix and verify shadow / shape / clip Sep 28, 2024
@PureWeen PureWeen modified the milestones: .NET 8 SR9, .NET 8 SR9.2 Oct 1, 2024
@jsuarezruiz
Copy link
Contributor

Current behavior of clipping / shadow / shape is completely messed up on different platform, I'm moving this to Draft.

image

Could you share a few notes of the differences found between platforms?

@albyrock87
Copy link
Contributor Author

@jsuarezruiz as you can see from my screenshot (android vs iOS), it appears that Clip interferes with Shadow in different ways:

  • on Android the Shadow is being applied to the "clip area"
  • on iOS the Shadow is applied to the "content area" and then it gets clipped to the "clip area"

I've seen other differences between Shadow behavior on Label (depending if it has background or not).

I haven't tried windows platform yet.

Problem is: from a customer point of view I don't even know what I would expect.
Probably neither of current behavior.

I would likely expect the Shadow to be applied to the "Clipped Content".

@PureWeen PureWeen modified the milestones: .NET 8 SR9.2, .NET 9 SR1 Oct 10, 2024
@PureWeen PureWeen modified the milestones: .NET 9 SR1, .NET 9 SR2 Oct 30, 2024
@PureWeen PureWeen modified the milestones: .NET 9 SR2, .NET 9 SR3 Dec 4, 2024
@jfversluis jfversluis added the area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing community ✨ Community Contribution
Projects
Status: Changes Requested
Development

Successfully merging this pull request may close these issues.

5 participants