Fixed Microsoft.Maui.Controls 8.0.90 (Latest stable) Ruins Entry Controls #25006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @NirmalKumarYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
(It would be great to cover the test scenario in #25038.) |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Oct 4, 2024
| { | ||
| App.WaitForElement("button"); | ||
| App.Tap("button"); | ||
| VerifyScreenshot(); |
There was a problem hiding this comment.
Triggered the build, it should generate the reference snapshot for this test.
There was a problem hiding this comment.
Ok, already added the test snapshot.
There was a problem hiding this comment.
Thanks for the images
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
…araj/maui into fix-24783" This reverts commit 8d50a3c, reversing changes made to 15000b8.
…araj/maui into fix-24783" This reverts commit 15000b8, reversing changes made to daef7ed.
|
/azp run |
PureWeen
approved these changes
Oct 9, 2024
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
samhouts
added
the
fixed-in-net8.0-nightly
NirmalKumarYuvaraj
added
the
partner/syncfusion
samhouts
added
fixed-in-9.0.10
fixed-in-net8.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause
The TextBox style applied resulted in an incorrect column count, causing the deleteButton column to shift and misalign the layout.
Description of Change
The code was updated to correctly identify the deleteButton column, setting its width to 0 when the clearButton is not visible and to Auto when it is visible to ensure proper layout.
Validated the behaviour in the following platforms
Fixes
fixes #24783
fixes #25038
Output
Before
After