Match Catalyst Template to iOS for Shell Flyout Items #25056
Conversation
PureWeen
requested review from
jsuarezruiz,
tj-devel709,
davidortinau and
rmarinho
and removed request for
jsuarezruiz and
tj-devel709
| @@ -537,6 +537,16 @@ internal static DataTemplate CreateDefaultFlyoutItemCell(string textBinding, str | |||
| return grid; | |||
| }); | |||
| } | |||
|
|
|||
| #if NETSTANDARD | |||
| sealed class OperatingSystem | |||
There was a problem hiding this comment.
Is this the right place for it? Do we need this in more places?
There was a problem hiding this comment.
Maybe? The problem I ran into putting this into a more general place is that you start to get errors about "OperatingSystem" is defined in multiple places. Unfortunately, NS has the System.OperatingSystem type it just doesn't have anything useful for us.
Another thought I had was to just call it OperatingSystemNS and then add a special using at the top, which did work.
Not sure the cleverest way to make this reusable.
Maybe we add our own internal static? MAUIOS that we can use generally?
samhouts
added
fixed-in-net9.0-nightly
|
/backport to release/9.0.1xx |
|
Started backporting to release/9.0.1xx: https://github.com/dotnet/maui/actions/runs/11335293225 |
* Match Catalyst Template to iOS * - NS Fixes
samhouts
added
fixed-in-9.0.12
and removed
fixed-in-net9.0-nightly
Description of Change
When we added
Catalystduring our move from XF to MAUI we forgot to include certain styles forCatalystalongsideiOSFixes
Before
After