[Windows] Fix for the issue with Label text color when resetting from FormattedText. #25119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
fix-24516
branch
from
35f319d to
d67fd90
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
fix-24516
branch
from
d67fd90 to
74b3759
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
requested changes
Oct 10, 2024
src/Controls/src/Core/Label/Label.cs
Outdated
| @@ -55,7 +55,9 @@ public partial class Label : View, IFontElement, ITextElement, ITextAlignmentEle | |||
| { | |||
| var formattedString = ((FormattedString)oldvalue); | |||
| var label = ((Label)bindable); | |||
|
|
|||
| #if WINDOWS | |||
| (label.Handler as LabelHandler)?.PlatformView?.TextHighlighters?.Clear(); | |||
There was a problem hiding this comment.
Can this be moved to here?
Or into the extention method being called?
There was a problem hiding this comment.
I have moved the fix into the TextBlockExtensions and ensured that the issue is resolved. Please review it and share if you have any concerns.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Foda
approved these changes
Oct 15, 2024
PureWeen
approved these changes
Oct 15, 2024
sheiksyedm
added
the
partner/syncfusion
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause of the issue
When changing the label text to FormattedText with text color, and then switching back to normal text, the text retains the formatted text color. This is due to the TextHighlighter applied in the UpdateInlines method of FormattedStringExtensions, which is not cleared when reverting to normal text.
Description of Change
I cleared the TextHighlighters in the UpdateText method of the TextBlockExtensions class before setting the normal text, which resolves the issue and works fine.
Issues Fixed
Fixes #24516
Tested the behaviour in the following platforms
Screenshot
FormattedTextIssue.mp4
FormattedTextColorFixed.mp4