Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable TitleViewSetOnShellWorksAfterNavigation on Device Tests #25125

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Oct 8, 2024

Description of Change

We're running into a couple of issues right now with the iOS controls device tests running abnormally slow.

The TitleViewSetOnShellWorksAfterNavigation test is failing occasionally which is just compounding the problem. We have a PR here to move the test to Appium that we will resolve before NET9 GA.

It seems like this is a legitimate failure we'll need to address

@PureWeen PureWeen requested a review from a team as a code owner October 8, 2024 00:02
@jsuarezruiz jsuarezruiz added the area-testing Unit tests, device tests label Oct 8, 2024
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho rmarinho merged commit 24a553f into net9.0 Oct 8, 2024
121 checks passed
@rmarinho rmarinho deleted the disable_TitleViewSetOnShellWorksAfterNavigation branch October 8, 2024 10:47
@samhouts samhouts added the fixed-in-net9.0-nightly This may be available in a nightly release! label Oct 14, 2024
@PureWeen
Copy link
Member Author

/backport to release/9.0.1xx

Copy link
Contributor

Started backporting to release/9.0.1xx: https://github.com/dotnet/maui/actions/runs/11426884018

rmarinho pushed a commit that referenced this pull request Nov 4, 2024
* Increment build targets to iOS 18

* - increment xcode

* - additional bumps

* Update Versions.props

* Update NuGet.config

* Update EmbeddedFontLoader.iOS.cs

* - CA1422

* [housekeeping] Update & Consolidate Appium + driver versions (#24817)

* Update appium + driver versions

Updating to latest

* Move appium versions to eng/Versions.props

* Fix ps1 get-location

* Check if appium is completely missing too

No need to attempt to uninstall appium if it's not installed

* - bump versions

* - fix script

---------

Co-authored-by: Shane Neuville <shneuvil@microsoft.com>

* Update dependencies from https://github.com/dotnet/xharness build 20241009.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 10.0.0-prerelease.24501.1 -> To Version 10.0.0-prerelease.24509.1

# Conflicts:
#	eng/Version.Details.xml

* Update dotnet-tools.json

* Update Versions.props

* Update Version.Details.xml

* - fix logs

* Update UITest.cs

* Bump ASPNet Versions

# Conflicts:
#	eng/Versions.props

# Conflicts:
#	eng/Versions.props

* Update dependencies from https://github.com/dotnet/xharness build 20241024.9 (#25553)

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 10.0.0-prerelease.24514.1 -> To Version 10.0.0-prerelease.24524.9

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
# Conflicts:
#	.config/dotnet-tools.json
#	eng/Version.Details.xml
#	eng/Versions.props

* - update pools

* - update versions

* - update feed

* - fix package source

* - images fixes

* [release/9.0.1xx] [net9.0] Run device tests arm (#25375)

* Run on arm the device tests

* no brew

* install api35

* add log installdefault api

* use iOS pool

* Maybe try skip this on handlers main build

* Add new pool name

---------

Co-authored-by: Rui Marinho <me@ruimarinho.net>
# Conflicts:
#	eng/pipelines/common/device-tests-steps.yml
#	eng/pipelines/common/provision.yml
#	eng/pipelines/device-tests.yml
#	eng/pipelines/handlers.yml

* - add parameters

* Update provisioning.csx

* Update provisioning.csx

* - update iOS images

* Move TitleViewSetOnShellWorksAfterNavigation to Appium (#25094)

* Move TitleViewSetOnShellWorksAfterNavigation to Appium

* - give width to editor so that it's visible

* Disable TitleViewSetOnShellWorksAfterNavigation (#25125)

---------

Co-authored-by: Jonathan Dick <jodick@microsoft.com>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
@samhouts samhouts added fixed-in-9.0.10 and removed fixed-in-net9.0-nightly This may be available in a nightly release! labels Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing Unit tests, device tests fixed-in-9.0.10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants