-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS]Resolved Button Text Resets to Previous Value When Set to Empty String Programmatically. #25171
Merged
+69
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a Clicked event handler causes previously set buttons to revert to previous values
Hey there @Vignesh-SF3580! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
tj-devel709
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find :)
sheiksyedm
added
the
partner/syncfusion
Issues / PR's with Syncfusion collaboration
label
Dec 6, 2024
samhouts
added
fixed-in-9.0.10
fixed-in-net8.0-nightly
This may be available in a nightly release!
labels
Dec 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
community ✨
Community Contribution
fixed-in-9.0.10
fixed-in-net8.0-nightly
This may be available in a nightly release!
partner/syncfusion
Issues / PR's with Syncfusion collaboration
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause
The issue stems from UIButton managing text through two properties: CurrentTitle and TitleLabel.Text. When the button’s text is updated or cleared (set to empty), only CurrentTitle gets refreshed, while TitleLabel.Text retains the original value. This discrepancy causes the outdated text from TitleLabel.Text to reappear during the button's re-measurement, as the native-level TitleLabel.Text remains unchanged.
Description of Change
Assigned an empty string to TitleLabel when the Button Text is empty. This ensures that the title label properly reflects the current state of the button, preventing the issue where the button text would revert to its previous value during layout updates or re-measurement.
Issues Fixed
Fixes #18235
Tested the behaviour in the following platforms
Screenshots
Mac:
MAC.Before.mov
Screen.Recording.2024-10-10.at.2.27.42.PM.3.mov
iOS:
IOS.Before.mov
IOS.After.mov