[XC] Add file info to exception reports #25359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDelcroix
force-pushed
the
missingfileinfo
branch
from
cd36dff to
9aefceb
Compare
StephaneDelcroix
force-pushed
the
missingfileinfo
branch
from
9aefceb to
879ebb9
Compare
| @@ -76,7 +76,7 @@ static void ParseXamlElementFor(IElementNode node, XmlReader reader) | |||
| name = new XmlName(reader.NamespaceURI, reader.LocalName); | |||
|
|
|||
| if (node.Properties.ContainsKey(name)) | |||
| throw new XamlParseException($"'{reader.Name}' is a duplicate property name.", (IXmlLineInfo)reader); | |||
| throw new XamlParseException($"'{reader.Name}' is a duplicate property name.", ((IXmlLineInfo)reader).Clone()); | |||
There was a problem hiding this comment.
reader is disposed before the message is logged, so the line info was missing
| var rootnode = ParseXaml(resource.GetResourceStream(), typeDef); | ||
| if (rootnode == null) | ||
| ILRootNode rootnode = null; | ||
| try { |
There was a problem hiding this comment.
this try/catch is the main change, the rest is pulling #22808
|
@StephaneDelcroix Could you rebase? Thanks in advance. |
StephaneDelcroix
force-pushed
the
missingfileinfo
branch
from
879ebb9 to
a6dc06b
Compare
StephaneDelcroix
force-pushed
the
missingfileinfo
branch
from
a6dc06b to
c6a6f29
Compare
jfversluis
approved these changes
Nov 27, 2024
rmarinho
approved these changes
Nov 28, 2024
samhouts
added
fixed-in-9.0.21
fixed-in-net8.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When the XamlParser throws an exception while executed from XamlC, the file info is missing from the log, and the whole XamlC process fails, so it only reports one issue at a time.
It now logs things like
Issues Fixed
Fixes #21038