[XC] Avoid NativeAOT trim warnings for compiled bindings #25396
Conversation
simonrozsival
changed the title
simonrozsival
requested review from
PureWeen and
tj-devel709
and removed request for
a team
| if (context.ValidateOnly) | ||
| { | ||
| yield break; | ||
| } |
There was a problem hiding this comment.
Is there a reason for reverting #24493 ?
There was a problem hiding this comment.
Without this change, the test doesn't work (the service provider isn't instantiated at all so I cannot inspect the code that we generate). I'm considering letting the tests pass and then remove the test + the changes in this file and keep just the fix itself to avoid perf regressions (cc @jonathanpeppers).
There was a problem hiding this comment.
I'm OK to take the if (ValidateOnly) check out, if this fixes something. It's still in a couple other places.
The problem with it generally:
- If there is some code path that needs to emit an error/warning
- The
if (ValidateOnly)would skip it
So, I was trying to put it places where we'd get free perf and not lose any errors or warnings.
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
| @@ -151,6 +151,8 @@ public class XamlCTask : XamlTask | |||
| /// </summary> | |||
| public bool ValidateOnly { get; set; } | |||
|
|
|||
| internal bool GenerateFullILInValidateOnlyMode { get; set; } | |||
There was a problem hiding this comment.
Does a .targets file need to set this? It could be a private property like $(_MauiGenerateFullILInValidateOnlyMode) for now.
There was a problem hiding this comment.
No, this is meant just for tests and so it's internal. I don't think this can even be set from the targets file.
|
Closing in favor of #25420 |
Contributes to #25406
Description of Change
The
BindingExtensionclass has an attribute that tells XamlC to include theXamlTypeResovlerin the service provider when calling theProvideValuemethod:maui/src/Controls/src/Xaml/MarkupExtensions/BindingExtension.cs
Lines 9 to 10 in 70f1f76
The
XamlTypeResovleris not trim and AOT compatible. Fortunately, it is NOT necessary when the binding is compiled. This PR adds a workaround that will prevent generating the faulty code in .NET 9. I think we should follow-up on this later in .NET 10 and properly compile theBindingExtension(see the referenced issue for more details).