[X] Delay binding context type check until relative binding source is resolved #25600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrozsival
requested review from
jsuarezruiz,
tj-devel709,
StephaneDelcroix and
PureWeen
and removed request for
a team
simonrozsival
force-pushed
the
dev/simonrozsival/fix-relative-bindings-runtime-check-for-type-mismatch
branch
from
4a0d2f6 to
bdbabd1
Compare
|
/backport to release/9.0.1xx |
|
Started backporting to release/9.0.1xx: https://github.com/dotnet/maui/actions/runs/11598728541 |
jsuarezruiz
previously approved these changes
Oct 31, 2024
jonathanpeppers
approved these changes
Oct 31, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Oct 31, 2024
jsuarezruiz
approved these changes
Nov 4, 2024
StephaneDelcroix
approved these changes
Nov 4, 2024
StephaneDelcroix
deleted the
dev/simonrozsival/fix-relative-bindings-runtime-check-for-type-mismatch
branch
samhouts
added
fixed-in-9.0.10
fixed-in-net8.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
We are checking if the binding context type matches the declared
x:DataTypetoo early. We need to wait until we resolve relative source otherwise the binding doesn't work.Fixes #25608
/cc @PureWeen @StephaneDelcroix