Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the iOS BackButton title does not update when set to an empty string or whitespace #25813

Merged
merged 6 commits into from
Nov 26, 2024
Merged

Fixed the iOS BackButton title does not update when set to an empty string or whitespace #25813

merged 6 commits into from
Nov 26, 2024

Conversation

NanthiniMahalingam
Copy link
Contributor

@NanthiniMahalingam NanthiniMahalingam commented Nov 13, 2024 •
edited
Loading

Root cause

  • For an empty string, the text does not override the previous page title. The default behavior of using the previous page title should only apply when the text is null.

Description of changes

  • The new UIBarButtonItem is created, and the back button title is overridden with the text when the text is not null.
  • Therefore, the text is also overridden with an empty string or whitespace.

Issues Fixed

Fixes #25742

Tested the behavior in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

ScreenShot

iOS

Before changes

BackButton_Behavior.mp4

After changes

BackButtonIssueFixed.mp4

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Nov 13, 2024
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 14, 2024
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@NanthiniMahalingam NanthiniMahalingam marked this pull request as ready for review November 18, 2024 07:04
@NanthiniMahalingam NanthiniMahalingam requested a review from a team as a code owner November 18, 2024 07:04
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen
Copy link
Member

/rebase

@PureWeen
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho rmarinho merged commit c49de14 into dotnet:main Nov 26, 2024
106 checks passed
@rmarinho rmarinho added this to the .NET 9 SR2 milestone Nov 26, 2024
@sheiksyedm sheiksyedm added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 6, 2024
@samhouts samhouts added fixed-in-9.0.21 fixed-in-net8.0-nightly This may be available in a nightly release! labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

@rmarinho rmarinho rmarinho approved these changes

@PureWeen PureWeen Awaiting requested review from PureWeen PureWeen is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-navigation NavigationPage community ✨ Community Contribution fixed-in-9.0.21 fixed-in-net8.0-nightly This may be available in a nightly release! partner/syncfusion Issues / PR's with Syncfusion collaboration platform/iOS 🍎
Projects
None yet
Milestone
.NET 9 SR2
Development

Successfully merging this pull request may close these issues.

iOS BackButton Title cannot be set to string.Empty or ""
6 participants
@NanthiniMahalingam @jsuarezruiz @PureWeen @rmarinho @samhouts @sheiksyedm