Fixed Keyboard Scrolling in editors with Center or End VerticalTextAlignment #25827
Conversation
jsuarezruiz
added
area-keyboard
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
fix-24977
branch
from
36adb36 to
025744d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
fix-24977
branch
from
025744d to
6fea74e
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Looks like this changed the behavior of the placeholder a tad. Looks like it is moved down a little and is being cut off a little bit on the top Original is on the left, the diff is in the middle, and the new behavior from this PR is on the right 
|
| { | ||
| var contentHeight = ContentSize.Height; | ||
| var contentHeight = ContentSize.Height - TextContainerInset.Top - TextContainerInset.Bottom; | ||
| var availableSpace = Bounds.Height - contentHeight * ZoomScale; | ||
| if (availableSpace <= 0) | ||
| return; | ||
| ContentOffset = VerticalTextAlignment switch | ||
|
|
||
| TextContainerInset = VerticalTextAlignment switch | ||
| { | ||
| Maui.TextAlignment.Center => new CGPoint(0, -Math.Max(1, availableSpace / 2)), | ||
| Maui.TextAlignment.End => new CGPoint(0, -Math.Max(1, availableSpace)), | ||
| _ => ContentOffset, | ||
| Maui.TextAlignment.Center => new UIEdgeInsets((nfloat)Math.Max(1, availableSpace / 2), TextContainerInset.Left, TextContainerInset.Bottom, TextContainerInset.Right), | ||
| Maui.TextAlignment.End => new UIEdgeInsets((nfloat)Math.Max(1, availableSpace), TextContainerInset.Left, TextContainerInset.Bottom, TextContainerInset.Right), | ||
| _ => TextContainerInset, |
There was a problem hiding this comment.
So it looks like the failing tests aren't just from the placeholder, but the spacing is just not correct and not accounting for the bottom of the TextContainerInset correctly. The following gets us closer and seems like the middle adjustment is a rounding issue perhaps. Can you look into this?
void ShouldCenterVertically()
{
// ContentSize.Height rounds to the nearest whole number so to keep the measurements consistent we round the adjustment as well
var contentHeight = ContentSize.Height - Math.Round(TextContainerInset.Top, MidpointRounding.AwayFromZero);;
var availableSpace = Bounds.Height - contentHeight * ZoomScale;
if (availableSpace <= 0)
return;
TextContainerInset = VerticalTextAlignment switch
{
Maui.TextAlignment.Center => new UIEdgeInsets((nfloat)Math.Max(1, availableSpace / 2), TextContainerInset.Left, TextContainerInset.Bottom, TextContainerInset.Right),
Maui.TextAlignment.End => new UIEdgeInsets((nfloat)Math.Max(1, availableSpace), TextContainerInset.Left, TextContainerInset.Bottom, TextContainerInset.Right),
_ => TextContainerInset,
};
}There was a problem hiding this comment.
This is the new diff from the code above
There was a problem hiding this comment.
There are more tests that would require a similar change
There was a problem hiding this comment.
@jsuarezruiz , EditorPlaceholderPosition is the test case related to this PR. The other test cases are unrelated, as this PR contains code changes for UITextView, and the remaining test cases do not involve an editor in their scenarios. To confirm, I ran both test cases locally, and they passed.
There was a problem hiding this comment.
@tj-devel709 , The rounding approach for middle alignment does not resolve the issue. I attempted to recalculate the position when the text alignment is set to center. Using this approach, we obtained the correct value, which is 66.25. This value is required for the test case to pass; however, the test still fails, even though the top inset value is set to 66.25.
void ShouldCenterVertically()
{
// ContentSize.Height rounds to the nearest whole number so to keep the measurements consistent we round the adjustment as well
var contentHeight = ContentSize.Height - Math.Round(TextContainerInset.Top, MidpointRounding.AwayFromZero);
var availableSpace = Bounds.Height - contentHeight * ZoomScale;
if (availableSpace <= 0)
return;
TextContainerInset = VerticalTextAlignment switch
{
Maui.TextAlignment.Center => new UIEdgeInsets((nfloat)Math.Max(1,(Bounds.Height - (ContentSize.Height - (TextContainerInset.Top + TextContainerInset.Bottom)) * ZoomScale) / 2), TextContainerInset.Left, TextContainerInset.Bottom, TextContainerInset.Right),
Maui.TextAlignment.End => new UIEdgeInsets((nfloat)Math.Max(1, availableSpace), TextContainerInset.Left, TextContainerInset.Bottom, TextContainerInset.Right),
_ => TextContainerInset,
};
}New diff from the above code
There was a problem hiding this comment.
Huh.. that looks pretty close so I'm not sure what is off here. It looks like maybe its just off by a fraction of a pixel or something like that. @PureWeen, what do you think? Good enough?
There was a problem hiding this comment.
@PureWeen, can you please share your thoughts on this?
NirmalKumarYuvaraj
added
the
partner/syncfusion
|
/rebase |
github-actions
bot
force-pushed
the
fix-24977
branch
from
9393e16 to
ffa07cc
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Yeah that is a weird behavior... Not sure what to immediately make of it other than the first behavior seems like the expected |
NirmalKumarYuvaraj
changed the title
Issue Details
Sometimes, the editor cursor moves below the keyboard frame, causing it to render incorrectly. Once the editor content exceeds the editor's size, the cursor aligns properly above the keyboard frame.
Root Cause
The content offset of UITextView is set without consideration of keyboard frame. Causing the content to remain center even when the keyboard is open. As a result, the cursor goes below the keyboard frame.
Description of Change
The content offset of UITextView should be recalculated based on the keyboard frame value . We should check if the cursor's bottom position goes below the keyboard; we have to update the y position of the content offset based on the difference between the cursor's bottom position and the keyboard frame's top position.
Validated the behaviour in the following platforms
Issues Fixed
Fixes #24977
Output
Before.mov
After.mov