-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Fixed HeaderFooterGrid to pass on CV1 and CV2 #26022
Conversation
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It s failing some tests..
https://dev.azure.com/xamarin/public/_apis/test/Runs/3418613/Results/100053/Attachments/14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rmarinho, In CV1, It appears that the VerticalItemsSpacing in the GridItemsLayout is creating excessive spacing in the last section of the items layout. The build failures are due to these ItemSpacing discrepancies, resulting in snapshot mismatches. The following Issue was previously identified and resolved, and a separate PR was created. PR Link Reference => #25825 In this Focused PR, We have made targeted changes specifically to resolve the VerticalItemsSpacing issue for the last section of CV items. We expect the next CI run to pass with these updates. Please review the PR and let us know if any further clarification. |
I implemented a fix for the CV VerticalSpacing issue to address a test case failure. However, since the same changes were recently merged. I have reverted my changes. PR => dotnet#25882
This reverts commit 47e9893.
This reverts commit 0e5aabf.
Azure Pipelines successfully started running 3 pipeline(s). |
We have attached the original and error snapshot images for reference. As highlighted by the difference between the two, there is a noticeable pixel error in the layout of the header and footer Grid in the CV1 snapshot. Would it be possible to replace the header and footer Grid image for this case or are there other adjustments we can make to resolve this pixel discrepancy? Please share your thoughts on this. Looking forward to your feedback! Thank you in advance. |
Can we try replace the image to check if it passes? |
Thank you for the suggestion. We will replace the header and footer Grid images to check if the build passes with the updated snapshot. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/rebase |
Issue details
The size of the CollectionView, including the header and footer, is not rendered correctly on the UI in CV1 but displays correctly in CV2.
Root cause
The GetSize() method calculated the size of the CollectionView based only on its content, ignoring the header and footer sizes. This caused incorrect height or width rendering when a header or footer was used.
Description of Change
The fix calculates the sizes of the header and footer using helper methods, This ensures the total size includes all elements, and the result is adjusted to fit within the CollectionView bounds.
Issues Fixed
Fixes #25773
Tested the behaviour in the following platforms
Output Screenshot