[Testing] Fix randomly failing tests on CI #26120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
commented
Nov 26, 2024
| @@ -104,16 +104,17 @@ public override void Reset() | |||
| App.ResetApp(); | |||
| } | |||
|
|
|||
| public void VerifyScreenshot(string? name = null) | |||
| public void VerifyScreenshot(string? name = null, TimeSpan? retryDelay = null) | |||
There was a problem hiding this comment.
Allow to set the retry waiting time verifying snapshots.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
commented
Nov 26, 2024
PureWeen
reviewed
Nov 27, 2024
| VerifyScreenshot(); | ||
|
|
||
| Thread.Sleep(1000); | ||
| VerifyScreenshot(retryDelay: TimeSpan.FromSeconds(2)); |
There was a problem hiding this comment.
I think we just build this retry into VertifyScreenshot by default for Android so we don't have to pass it
There was a problem hiding this comment.
Yeah, just increase the waiting time between snapshots.
jsuarezruiz
commented
Nov 27, 2024
| @@ -1,4 +1,4 @@ | |||
| #if ANDROID | |||
| #if ANDROID && TEST_FAILS_ON_ANDROID // Related issue: https://github.com/dotnet/maui/issues/26159 | |||
There was a problem hiding this comment.
Created a new related issue
rmarinho
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Changes to fix randomly failing tests on CI. The failing tests are: