Fixed Unable to Remove Thumb Image in Slider Control #26129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed Editor and ScrollView problems in iOS
This reverts commit 476f3c3.
Fixed Unable to Remove Thumb Image in Slider Control
jsuarezruiz
reviewed
Nov 26, 2024
Reverted the fix for iOS platform.
|
This fix is similar to #26085. Hence closing the PR. |
NirmalKumarYuvaraj
added
the
partner/syncfusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Details:
Editor's width and height is not updated when changing the device orientation from landscape to portrait.
Root Cause:
We updated ThumbImageSource is not null to the native view of Slider. So it fails to update if ThumbImageSource is null to native view(uiSlider) on SliderExtensions class.
Description of Change:
I initially stored the seekBar.Thumb in the defaultDrawable property. When a custom image is set to the ThumbImageSource property, the seekBar.Thumb becomes a BitmapDrawable. After setting null to the ThumbImageSource property, I updated seekBar.Thumb with the value from the defaultDrawable property.
Tested the behavior in the following platforms.
Reference:
N/A
Issues Fixed:
Fixes #25939
Screenshots