-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] See if we can provision by default on devdiv #26170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
try again Variables Fix provisioning is it this try this try again try pass variable to all
rmarinho
added
the
area-infrastructure
CI, Maestro / Coherency, upstream dependencies/versions
label
Nov 27, 2024
rmarinho
changed the title
[ci] See if we can provision default this on devdiv
[ci] See if we can provision by default on devdiv
Nov 27, 2024
rmarinho
commented
Nov 27, 2024
eng/pipelines/handlers.yml
Outdated
@@ -197,7 +197,7 @@ stages: | |||
skipAndroidImages: true | |||
installDefaultAndroidApi: false | |||
skipXcode: ${{ ne(BuildPlatform.name , 'macOS') }} | |||
${{ if parameters.UseProvisionator }}: | |||
${{ if or(parameters.UseProvisionator, variables['internalProvisioning']) }}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattleibow I can t get this to work, the idea is we could use the variable or set as default on devdiv.. do you have any idea what I m missing seems this is never true its always passing skipProvisioning: false
rmarinho
requested review from
mattleibow and
Redth
and removed request for
StephaneDelcroix
November 28, 2024 14:20
samhouts
added
fixed-in-9.0.21
fixed-in-net8.0-nightly
This may be available in a nightly release!
labels
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-infrastructure
CI, Maestro / Coherency, upstream dependencies/versions
fixed-in-9.0.21
fixed-in-net8.0-nightly
This may be available in a nightly release!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Set variables to provision the certs by default on DevDiv, and allow to manually started on xamarin instance
The idea is to have two variables UseProvisionator that can be set at queue time and a internalProvisioning that is set on the pipeline on devdiv.
It also now allows to by demand provision a bot on xamarin public azdo instance
Example pipeline
https://dev.azure.com/xamarin/public/_build/results?buildId=129622&view=logs&j=7b56c296-8a0a-5e10-b668-0a573fbf1ddf&t=29de6a03-df83-5147-affc-5206150077b8
Issues Fixed
Fixes #25948