Change Yaml to use OneLocTool to create PR after we receive the lcl files #26177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tj-devel709
added
area-templates
jfversluis
approved these changes
Nov 28, 2024
jsuarezruiz
approved these changes
Nov 28, 2024
samhouts
added
fixed-in-9.0.21
fixed-in-net8.0-nightly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
After we receive the lcl file updates from the OneLoc tool in PRs such as this: https://github.com/dotnet/maui/pull/25933/files, we need to also run the OneLocTool with the flag
isCreatePrSelectedset to true to ensure the tool uses those translations from the lcl files and puts them in the json and resx files to be used by customers. There was more logic in the eng/pipelines/common/localization-handback.yml and eng/pipelines/common/merge-translations-update.yml but I opted to simplify it for now to make sure we are on track to get these PRs created.Issues Fixed
Fixes #26176