Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provided description for "checkboxes", "clear" and "New Task" button #26192

Closed
wants to merge 3 commits into from

Conversation

Vignesh-SF3580
Copy link
Contributor

Issue Detail

Some UI elements in the ".NET 9 template" app lack semantic names, impacting screen reader usability.

Description of Change

Added SemanticProperties.Description to checkboxes, NewTask button, and Clear button

Issues Fixed

Fixes #26128

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Nov 28, 2024
@jsuarezruiz jsuarezruiz added area-templates Project templates, Item Templates for Blazor and MAUI t/a11y Relates to accessibility labels Nov 28, 2024
@Vignesh-SF3580 Vignesh-SF3580 marked this pull request as ready for review November 29, 2024 14:01
@Vignesh-SF3580 Vignesh-SF3580 requested a review from a team as a code owner November 29, 2024 14:01
@rmarinho
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sheiksyedm sheiksyedm added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 6, 2024
@@ -9,4 +9,6 @@
WidthRequest="60"
VerticalOptions="End"
HorizontalOptions="End"
Margin="30" />
Margin="30"
SemanticProperties.Description="New Task Button"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we just set the Description to "Add a new task" and then don't supply a "Hint"

I think that will cover it right?

Same comment goes for the other buttons in this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the code based on your feedback. Could you please review it and let me know if there are any further concerns

@PureWeen
Copy link
Member

PureWeen commented Jan 6, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Vignesh-SF3580
Copy link
Contributor Author

Reported issue was resolved in the following PRs.
#26920
#26919
#26903
#26921

@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-templates Project templates, Item Templates for Blazor and MAUI community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration t/a11y Relates to accessibility
Projects
None yet
5 participants