Skip to content

Fixed picker allows user input if the keyboard is visible #26382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 28, 2025
Merged

Fixed picker allows user input if the keyboard is visible #26382

merged 10 commits into from
May 28, 2025

Conversation

@NirmalKumarYuvaraj
Copy link
Contributor

@NirmalKumarYuvaraj NirmalKumarYuvaraj commented Dec 5, 2024 •
edited
Loading

Issue Details

User can input text when keyboard is open in picker.

Root Cause

The base view for the picker in the unfocused state is AppCompatEditText. It allows the user to edit using keyboard.

Description of Change

Setting the e.Handled to true in the KeyPress will prevent from further processing of the keys.

Validated the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Issues Fixed

Fixes #24930
Fixes #8265

Output

Before After
Before.mov
After.mov

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Dec 5, 2024
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Dec 5, 2024

Hey there @NirmalKumarYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@sheiksyedm sheiksyedm added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 5, 2024
@NirmalKumarYuvaraj NirmalKumarYuvaraj marked this pull request as ready for review December 5, 2024 15:28
@NirmalKumarYuvaraj NirmalKumarYuvaraj requested a review from a team as a code owner December 5, 2024 15:28
@Redth
Copy link
Member

Redth commented Dec 5, 2024

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 5, 2024

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho
Copy link
Member

rmarinho commented Dec 7, 2024 •
edited by jfversluis
Loading

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 7, 2024

Azure Pipelines successfully started running 3 pipeline(s).

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 13, 2024

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz
jsuarezruiz reviewed Jan 10, 2025
View reviewed changes
@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Jan 14, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 14, 2025

Azure Pipelines successfully started running 3 pipeline(s).

@codeinapt

This comment was marked as off-topic.

Sign in to view
@s-beji

This comment was marked as off-topic.

Sign in to view
PureWeen
PureWeen requested changes Feb 19, 2025
View reviewed changes
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. if we make these changes I think they should be moved here

    maui/src/Core/src/Platform/Android/PickerManager.cs

    Line 18 in b17db5e

    public static void Init(EditText editText)

  2. From looking at PickerManager it doesn't look like we want to completely disable the keyboard

@NirmalKumarYuvaraj
Copy link
Contributor Author

NirmalKumarYuvaraj commented Feb 20, 2025 •
edited
Loading

  1. if we make these changes I think they should be moved here

    maui/src/Core/src/Platform/Android/PickerManager.cs

    Line 18 in b17db5e

    public static void Init(EditText editText)
  2. From looking at PickerManager it doesn't look like we want to completely disable the keyboard

@PureWeen , I have modified the code changes. please let me know if you have any concerns.

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Feb 26, 2025

/rebase

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Feb 26, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 26, 2025

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz
jsuarezruiz previously requested changes Feb 26, 2025
View reviewed changes
PureWeen
PureWeen previously requested changes Feb 26, 2025
View reviewed changes
src/Core/src/Platform/Android/PickerManager.cs
static void OnKeyPress(object? sender, AView.KeyEventArgs e)
{
//To prevent user from entering text when focus is received
e.Handled = true;
Copy link
Member

@PureWeen PureWeen Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we'll want to handle every single keypress event.

This will probably break scenarios where a user has a hardware keyboard connected to the device and is trying to use tab to navigate components

Copy link
Contributor Author

@NirmalKumarYuvaraj NirmalKumarYuvaraj Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PureWeen , Pressing the Tab key focuses on the EditText, causing the picker dialog to open. Navigation does not occur between the components. According to the implementation, a change in focus triggers the dialog to appear on the view. I have shared a video for reference. please let me know if you have any concerns.

Screen.Recording.2025-03-11.at.5.33.22.PM.mov

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Mar 26, 2025

/rebase

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Mar 27, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 27, 2025

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen moved this from Todo to Ready To Review in MAUI SDK Ongoing Apr 18, 2025
@PureWeen PureWeen modified the milestones: .NET 9 SR7, .NET 9 SR8 May 8, 2025
@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented May 19, 2025

/rebase

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented May 19, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented May 19, 2025

Azure Pipelines successfully started running 3 pipeline(s).

@mattleibow mattleibow moved this from Ready To Review to Approved in MAUI SDK Ongoing May 23, 2025
@mattleibow mattleibow dismissed stale reviews from jsuarezruiz and PureWeen May 23, 2025 11:51

Code changes made.

@rmarinho rmarinho merged commit 228b7bf into dotnet:main May 28, 2025
129 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing May 28, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mattleibow mattleibow mattleibow approved these changes

@StephaneDelcroix StephaneDelcroix StephaneDelcroix left review comments

@PureWeen PureWeen PureWeen left review comments

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 was automatically assigned from dotnet/dotnet-maui-reviewers

+1 more reviewer

@jsuarezruiz jsuarezruiz jsuarezruiz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-controls-picker Picker community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

MAUI SDK Ongoing
Status: Done

Milestone

.NET 9 SR8

Development

Successfully merging this pull request may close these issues.

The picker allows you to write text if the keyboard is visible Android Picker Issue (User can input text)