-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The fix for child FlexLayout content appearing no longer works starting from version 8.0.61 #26665
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+59.7 KB
...estCases.Android.Tests/snapshots/android/ChildFlexLayoutContentShouldAppear.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
using Microsoft.Maui.Layouts; | ||
|
||
namespace Maui.Controls.Sample.Issues | ||
{ | ||
[Issue(IssueTracker.Github, 23491, "BindableLayout.ItemsSource no longer works in 8.0.61", PlatformAffected.All)] | ||
public class Issue23491 : ContentPage | ||
{ | ||
Label headerLabel; | ||
Label label1; | ||
Label label2; | ||
public Issue23491() | ||
{ | ||
headerLabel = new Label { Text = "Below is the Content of the Child FlexLayout", | ||
TextColor=Colors.Red }; | ||
|
||
headerLabel.AutomationId = "HeaderLabel"; | ||
|
||
// Child FlexLayout | ||
label1 = new Label | ||
{ | ||
Text = "First label inside the child flexlayout", | ||
Padding =new Thickness(5) | ||
}; | ||
|
||
label2 = new Label | ||
{ | ||
Text = "Second label inside the child flexLayout", | ||
Padding =new Thickness(5) | ||
}; | ||
|
||
var childFlexLayout = new FlexLayout | ||
{ | ||
Margin = new Thickness(10), | ||
Wrap = FlexWrap.Wrap, | ||
Children = { label1, label2 } | ||
}; | ||
|
||
// Main FlexLayout | ||
var mainLayout = new FlexLayout | ||
{ | ||
Direction = FlexDirection.Column, | ||
Children = { headerLabel, childFlexLayout } | ||
}; | ||
|
||
// Set the content of the page | ||
Content = mainLayout; | ||
} | ||
} | ||
} |
21 changes: 21 additions & 0 deletions
21
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue23491.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
using NUnit.Framework; | ||
using UITest.Appium; | ||
using UITest.Core; | ||
|
||
namespace Microsoft.Maui.TestCases.Tests.Issues | ||
{ | ||
public class Issue23491 : _IssuesUITest | ||
{ | ||
public Issue23491(TestDevice device) : base(device) { } | ||
|
||
public override string Issue => "BindableLayout.ItemsSource no longer works in 8.0.61"; | ||
|
||
[Test] | ||
[Category(UITestCategories.Label)] | ||
public void ChildFlexLayoutContentShouldAppear() | ||
{ | ||
App.WaitForElement("HeaderLabel"); | ||
VerifyScreenshot(); | ||
} | ||
} | ||
} |
Binary file added
BIN
+5.43 KB
.../TestCases.WinUI.Tests/snapshots/windows/ChildFlexLayoutContentShouldAppear.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+65.1 KB
.../tests/TestCases.iOS.Tests/snapshots/ios/ChildFlexLayoutContentShouldAppear.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change in the delegate signature is potentially a breaking change. Please ensure that this change is documented and communicated appropriately.
This comment was generated based on a coding guideline created by a repository admin.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.