Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #26769 - crash when iOS app is running on MacOS #26771

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

VitalyKnyazev
Copy link
Contributor

Fixed issue #26769 - crash when iOS app is running on MacOS and "More" item is clicked in ListView context menu.

Description of Change

Checking PopoverPresentationController for null, it seems to be null checked already in all other places.

Issues Fixed

Fixes #26769

… item is clicked in ListView context menu. Checking PopoverPresentationController for null, it seems to be null checked already in all other places.
@VitalyKnyazev VitalyKnyazev requested a review from a team as a code owner December 20, 2024 20:04
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Dec 20, 2024
Copy link
Contributor

Hey there @VitalyKnyazev! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@PureWeen PureWeen added this to the .NET 9 SR4 milestone Dec 20, 2024
@jfversluis
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen added the area-controls-listview ListView and TableView label Dec 26, 2024
mattleibow

This comment was marked as off-topic.

@mattleibow mattleibow enabled auto-merge (squash) January 15, 2025 16:06
@PureWeen PureWeen disabled auto-merge January 15, 2025 16:08
@PureWeen
Copy link
Member

  • these changes only touched iOS so we can merge despite the WinUI tests here

@PureWeen PureWeen merged commit 7c3e886 into dotnet:main Jan 15, 2025
103 of 105 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-listview ListView and TableView community ✨ Community Contribution
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] ListView context item "More" crashes iOS app running on macOS 14+
4 participants