Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Fix for Left SwipeView Items Conflict with Shell Menu Swipe Gesture #26976

Merged
merged 3 commits into from
Jan 30, 2025
Merged

[iOS] Fix for Left SwipeView Items Conflict with Shell Menu Swipe Gesture #26976

merged 3 commits into from
Jan 30, 2025

Conversation

Tamilarasan-Paranthaman
Copy link
Contributor

Root Cause of the issue

  • When swiping to the left in the SwipeView, the shell flyout gesture intercepts the SwipeView gesture and causes the shell flyout to open.

Description of Change

  • I resolved the issue by identifying if the view is a MauiSwipeView. If it is, I restricted the touch interaction in the shell flyout, allowing the SwipeView touch gestures to work as expected.

Issues Fixed

Fixes #26933

Tested the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Screenshot

Before Issue Fix After Issue Fix
SwipeViewIssue.mov
SwipeViewFix.mov

Reference from Xamarin

https://github.com/xamarin/Xamarin.Forms/blob/2f8f4864a4d289dc89a6228e2ca9d6a49993e365/Xamarin.Forms.Platform.iOS/Renderers/ShellFlyoutRenderer.cs#L85

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jan 7, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hey there @Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@karthikraja-arumugam karthikraja-arumugam added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jan 7, 2025
@rmarinho
Copy link
Member

rmarinho commented Jan 7, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@Tamilarasan-Paranthaman Tamilarasan-Paranthaman marked this pull request as ready for review January 7, 2025 13:28
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman requested a review from a team as a code owner January 7, 2025 13:28
@jfversluis jfversluis added the area-controls-shell Shell Navigation, Routes, Tabs, Flyout label Jan 9, 2025
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen dismissed jsuarezruiz’s stale review January 30, 2025 18:46

Changes addressed

@PureWeen PureWeen merged commit 91aada4 into dotnet:main Jan 30, 2025
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PureWeen PureWeen PureWeen approved these changes

@jsuarezruiz jsuarezruiz jsuarezruiz left review comments

@mattleibow mattleibow Awaiting requested review from mattleibow mattleibow is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@rmarinho rmarinho Awaiting requested review from rmarinho rmarinho is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Left SwipeView Items Conflict with Shell Menu Swipe Gesture on iOS
6 participants
@Tamilarasan-Paranthaman @rmarinho @jsuarezruiz @PureWeen @jfversluis @karthikraja-arumugam