Improve debugger experience #27017
Merged
Improve debugger experience #27017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jfversluis
previously approved these changes
Jan 9, 2025
jfversluis
added
the
area-architecture
mattleibow
reviewed
Jan 9, 2025
rolfbjarne
reviewed
Jan 9, 2025
|
Azure Pipelines successfully started running 3 pipeline(s). |
dartasen
reviewed
Jan 9, 2025
|
|
||
| private protected override string GetDebuggerDisplay() | ||
| { | ||
| return $"IsRunning = {IsRunning}, " + base.GetDebuggerDisplay(); |
There was a problem hiding this comment.
Interpolating along with string concatenation ?
There was a problem hiding this comment.
would it cause any issue?
There was a problem hiding this comment.
would it cause any issue?
Typically one uses one or the other for consistency reasons, not both. I think one can do:
$"IsRunning = {IsRunning}, {(base.GetDebuggerDisplay())}";
There was a problem hiding this comment.
String concatenation should never be used in modern c#
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@pictos this needs a rebase for a failing UI test and not sure you want to address the feedback? For consistency might be nice |
|
@jfversluis I can do a rebase during the week. I can use just the interpolated string, but I don't see any issue on that |
pictos
force-pushed
the
pj/improve-debugger-display
branch
from
d0d0713 to
3507b52
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Co-authored-by: Gerald Versluis <gerald@verslu.is>
jfversluis
force-pushed
the
pj/improve-debugger-display
branch
from
3507b52 to
efc36b0
Compare
|
Azure Pipelines successfully started running 3 pipeline(s). |
jfversluis
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR adds the
DebuggerDisplayattribute over a good amount of controls and, this is the first step into improving the debug experience of .NET MAUIYou can find more images in the related issue
Issues Fixed
Related to #27016