[iOS] Fix for CarouselView ItemSpacing property in ItemsLayout not working with CV2 #27056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dotnet-policy-service agree company="Syncfusion, Inc." |
vishnumenon2684
added
the
partner/syncfusion
Contributor
Author
|
Hi @mattleibow, I have fixed the ItemSpacing issue in CarouselViewHandler2.iOS, which resolves the issues on both iOS and macOS. While testing to enable the test case in MacCatalyst, maximizing the window resulted in different behaviors in CV1 and CV2. As a result, I have not enabled the MacCatalyst condition yet. Could you please confirm the correct behavior on macOS—CV1 or CV2? Issue link : #26969 |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
previously requested changes
Jan 14, 2025
src/Controls/src/Core/Handlers/Items2/CarouselViewHandler2.iOS.cs
Outdated
Show resolved
Hide resolved
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Ahamed-Ali
force-pushed
the
fix-27025
branch
2 times, most recently
from
2c8d2d7 to
b3c0c0d
Compare
Contributor
|
/rebase |
github-actions
bot
force-pushed
the
fix-27025
branch
from
b3c0c0d to
f2dba16
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/rebase |
github-actions
bot
force-pushed
the
fix-27025
branch
from
0ad7670 to
eb90334
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
added
area-controls-collectionview
Contributor
|
/rebase |
github-actions
bot
force-pushed
the
fix-27025
branch
from
f136f15 to
a010a13
Compare
Contributor
|
@Ahamed-Ali If #29719 is merged before this, you may have to adjust your changes here accordingly. |
src/Controls/src/Core/Handlers/Items2/CarouselViewHandler2.iOS.cs
Outdated
Show resolved
Hide resolved
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bhavanesh2001
approved these changes
Jun 25, 2025
Contributor
bhavanesh2001
left a comment
bhavanesh2001
left a comment
There was a problem hiding this comment.
Changes seem fine based on our current layout creation.
mattleibow
approved these changes
Jun 26, 2025
mattleibow
dismissed
jsuarezruiz’s stale review
Test were already added. Clarified.
github-project-automation
bot
moved this from Ready To Review
to Done
in MAUI SDK Ongoing
github-actions bot
pushed a commit
that referenced
this pull request
Jun 29, 2025
…rking with CV2 (#27056) * Fixed the ItemSpacing issue in CV2 * reenabled the test * changed the fix based on conflicts file * Optimized the fix in the LayoutFactory2
github-actions bot
pushed a commit
that referenced
this pull request
Jun 29, 2025
…rking with CV2 (#27056) * Fixed the ItemSpacing issue in CV2 * reenabled the test * changed the fix based on conflicts file * Optimized the fix in the LayoutFactory2
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2025
…rking with CV2 (#27056) * Fixed the ItemSpacing issue in CV2 * reenabled the test * changed the fix based on conflicts file * Optimized the fix in the LayoutFactory2
github-actions bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
…rking with CV2 (#27056) * Fixed the ItemSpacing issue in CV2 * reenabled the test * changed the fix based on conflicts file * Optimized the fix in the LayoutFactory2
github-actions bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
…rking with CV2 (#27056) * Fixed the ItemSpacing issue in CV2 * reenabled the test * changed the fix based on conflicts file * Optimized the fix in the LayoutFactory2
github-actions bot
pushed a commit
that referenced
this pull request
Jul 8, 2025
…rking with CV2 (#27056) * Fixed the ItemSpacing issue in CV2 * reenabled the test * changed the fix based on conflicts file * Optimized the fix in the LayoutFactory2
github-actions bot
pushed a commit
that referenced
this pull request
Jul 8, 2025
…rking with CV2 (#27056) * Fixed the ItemSpacing issue in CV2 * reenabled the test * changed the fix based on conflicts file * Optimized the fix in the LayoutFactory2
github-actions bot
pushed a commit
that referenced
this pull request
Jul 9, 2025
…rking with CV2 (#27056) * Fixed the ItemSpacing issue in CV2 * reenabled the test * changed the fix based on conflicts file * Optimized the fix in the LayoutFactory2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause of the issue
The itemSpacing variable is initialized to 0. As a result, itemSpacing remains 0, and no spacing is applied between the items.
Description of Change
To resolve this, apply the correct item spacing from the LinearItemsLayout.
Issues Fixed
Fixes #27025
Tested the behaviour in the following platforms
Screenshot